Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Commit 16cc21f

Browse files
Merge pull request #29 from GoodNotes/fix-carton-build
Use carton jammy build and set carton toolchain
2 parents 978b7bf + c8a0adf commit 16cc21f

File tree

3 files changed

+30
-9
lines changed

3 files changed

+30
-9
lines changed

.github/workflows/docker.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ jobs:
4848
build-args: |
4949
SWIFLINT_DOCKER_IMAGE=ghcr.io/realm/swiftlint:0.46.5
5050
CARTON_TAG=0.19.1
51-
SWIFT_DOCKER_IMAGE=swift:5.8.0-focal
52-
SWIFT_TAG=swift-wasm-5.8.0-RELEASE
51+
SWIFT_DOCKER_IMAGE=swift:5.8.0-jammy
52+
SWIFT_TAG=wasm-5.8.0-RELEASE
5353
SWIFT_FORMAT_TAG=508.0.1
5454
NODE_VERSION=16.x
5555
OPEN_JDK_VERSION=11

Dockerfile

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@ ARG SWIFT_DOCKER_IMAGE
44
FROM $SWIFLINT_DOCKER_IMAGE as swiftLint
55

66
FROM $SWIFT_DOCKER_IMAGE as carton-builder
7+
ARG SWIFT_TAG
78
ARG CARTON_TAG
89
RUN apt-get update && apt-get install -y libsqlite3-dev
910
RUN git clone https://github.com/swiftwasm/carton.git && \
1011
cd carton && \
1112
git checkout "tags/$CARTON_TAG" && \
13+
export CARTON_DEFAULT_TOOLCHAIN=$SWIFT_TAG && \
1214
swift build -c release && \
1315
mv .build/release/carton /usr/bin
1416

@@ -26,13 +28,13 @@ RUN git clone https://github.com/apple/swift-format.git && \
2628
sed -i -e 's/.upToNextMinor(from: "0.50700.0")/exact: "0.50700.0"/' Package.swift && \
2729
swift build -c release
2830

29-
FROM ubuntu:20.04 as binaryen
31+
FROM ubuntu:22.04 as binaryen
3032

3133
RUN apt-get update && apt-get install -y curl
3234
RUN curl -L -v -o binaryen.tar.gz https://github.com/WebAssembly/binaryen/releases/download/version_105/binaryen-version_105-x86_64-linux.tar.gz
3335
RUN tar xzvf binaryen.tar.gz
3436

35-
FROM ubuntu:20.04 as symbolicator-builder
37+
FROM ubuntu:22.04 as symbolicator-builder
3638

3739
ARG SYMBOLICATOR_VERSION
3840
RUN apt-get update && apt-get install -y curl
@@ -42,11 +44,11 @@ FROM $SWIFT_DOCKER_IMAGE-slim as swiftwasm-builder
4244

4345
ARG SWIFT_TAG
4446
ARG NODE_VERSION
45-
ARG SWIFT_PLATFORM_SUFFIX=ubuntu20.04_x86_64.tar.gz
47+
ARG SWIFT_PLATFORM_SUFFIX=ubuntu22.04_x86_64.tar.gz
4648
ARG OPEN_JDK_VERSION
4749
ARG CYPRESS_VERSION
4850

49-
ARG SWIFT_BIN_URL="https://github.com/swiftwasm/swift/releases/download/$SWIFT_TAG/$SWIFT_TAG-$SWIFT_PLATFORM_SUFFIX"
51+
ARG SWIFT_BIN_URL="https://github.com/swiftwasm/swift/releases/download/swift-$SWIFT_TAG/swift-$SWIFT_TAG-$SWIFT_PLATFORM_SUFFIX"
5052

5153
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
5254
curl \
@@ -58,7 +60,7 @@ RUN curl -fsSL https://deb.nodesource.com/setup_${NODE_VERSION} | bash -
5860
ENV CARTON_ROOT=/root/.carton
5961

6062
# Download and Install swift toolchain (we need snapshot artifact for getting release Foundation library)
61-
RUN CARTON_DEFAULT_TOOLCHAIN_PATH="$CARTON_ROOT/sdk/${SWIFT_TAG#swift-}" \
63+
RUN CARTON_DEFAULT_TOOLCHAIN_PATH="$CARTON_ROOT/sdk/${SWIFT_TAG}" \
6264
&& curl -fsSL "$SWIFT_BIN_URL" -o swift.tar.gz \
6365
&& mkdir -p "$CARTON_DEFAULT_TOOLCHAIN_PATH" \
6466
&& tar -xzf swift.tar.gz --directory "$CARTON_DEFAULT_TOOLCHAIN_PATH" --strip-components=1 \
@@ -90,6 +92,7 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
9092
fonts-noto-color-emoji \
9193
fonts-indic \
9294
fonts-thai-tlwg-ttf \
95+
unzip \
9396
&& rm -rf /var/lib/apt/lists/*
9497

9598
# Install yarn

README.md

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ The collection of tools included are:
2323
$ docker build \
2424
--build-arg SWIFLINT_DOCKER_IMAGE=ghcr.io/realm/swiftlint:0.46.5 \
2525
--build-arg CARTON_TAG=0.19.1 \
26-
--build-arg SWIFT_DOCKER_IMAGE=swift:5.8.0-focal \
27-
--build-arg SWIFT_TAG=swift-wasm-5.8.0-RELEASE \
26+
--build-arg SWIFT_DOCKER_IMAGE=swift:5.8.0-jammy \
27+
--build-arg SWIFT_TAG=wasm-5.8.0-RELEASE \
2828
--build-arg SWIFT_FORMAT_TAG=508.0.1 \
2929
--build-arg NODE_VERSION=16.x \
3030
--build-arg OPEN_JDK_VERSION=11 \
@@ -38,6 +38,24 @@ $ docker build \
3838
## [TAGGED VERSIONS](https://github.com/GoodNotes/swiftwasm-frontend-docker/pkgs/container/swiftwasm-frontend-docker)
3939
Here you are a list of the tagged dockers with the specific tools version included.
4040

41+
### 0.0.29:
42+
43+
- Swift Web Assembly toolchain => `swift-wasm-5.8.0-RELEASE`
44+
- Carton => `0.19.1`
45+
- Binaryen => `105`
46+
- NodeJS => `v16.13.2`
47+
- Npm => `8.1.2`
48+
- Npx => `8.1.2`
49+
- Yarn => `1.22.17`
50+
- SwiftLint => `0.46.5`
51+
- SwiftFormat => `508.0.1`
52+
- Cypress => `12.3.0`
53+
- Brotli => `1.0.9`
54+
- Chrome => `101.0.4951.54`
55+
- ChromeDriver => `101.0.4951.41`
56+
- Firefox => `99.0.1`
57+
- Sentry Symbolicator => `0.5.0`
58+
4159
### 0.0.28:
4260

4361
- Swift Web Assembly toolchain => `swift-wasm-5.8.0-RELEASE`

0 commit comments

Comments
 (0)