Skip to content

Commit ab2882b

Browse files
authored
Don't use unknown for workbox-build method config (#3037)
* Don't use unknown for config * Relax internal type * Tweaked casting
1 parent b47500c commit ab2882b

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

packages/workbox-build/src/generate-sw.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import upath from 'upath';
1010

11-
import {BuildResult, GetManifestOptions} from './types';
11+
import {BuildResult, GetManifestOptions, GenerateSWOptions} from './types';
1212
import {getFileManifestEntries} from './lib/get-file-manifest-entries';
1313
import {rebasePath} from './lib/rebase-path';
1414
import {validateGenerateSWOptions} from './lib/validate-options';
@@ -193,7 +193,9 @@ import {writeSWUsingDefaultTemplate} from './lib/write-sw-using-default-template
193193
*
194194
* @memberof workbox-build
195195
*/
196-
export async function generateSW(config: unknown): Promise<BuildResult> {
196+
export async function generateSW(
197+
config: GenerateSWOptions,
198+
): Promise<BuildResult> {
197199
const options = validateGenerateSWOptions(config);
198200
let entriesResult;
199201

packages/workbox-build/src/get-manifest.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88

99
import {getFileManifestEntries} from './lib/get-file-manifest-entries';
10-
import {GetManifestResult} from './types';
10+
import {GetManifestOptions, GetManifestResult} from './types';
1111
import {validateGetManifestOptions} from './lib/validate-options';
1212

1313
// eslint-disable-next-line jsdoc/newline-after-description
@@ -88,7 +88,9 @@ import {validateGetManifestOptions} from './lib/validate-options';
8888
*
8989
* @memberof workbox-build
9090
*/
91-
export async function getManifest(config: unknown): Promise<GetManifestResult> {
91+
export async function getManifest(
92+
config: GetManifestOptions,
93+
): Promise<GetManifestResult> {
9294
const options = validateGetManifestOptions(config);
9395

9496
return await getFileManifestEntries(options);

packages/workbox-build/src/inject-manifest.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import fse from 'fs-extra';
1212
import stringify from 'fast-json-stable-stringify';
1313
import upath from 'upath';
1414

15-
import {BuildResult} from './types';
15+
import {BuildResult, InjectManifestOptions} from './types';
1616
import {errors} from './lib/errors';
1717
import {escapeRegExp} from './lib/escape-regexp';
1818
import {getFileManifestEntries} from './lib/get-file-manifest-entries';
@@ -117,7 +117,9 @@ import {validateInjectManifestOptions} from './lib/validate-options';
117117
*
118118
* @memberof workbox-build
119119
*/
120-
export async function injectManifest(config: unknown): Promise<BuildResult> {
120+
export async function injectManifest(
121+
config: InjectManifestOptions,
122+
): Promise<BuildResult> {
121123
const options = validateInjectManifestOptions(config);
122124

123125
// Make sure we leave swSrc and swDest out of the precache manifest.

packages/workbox-cli/src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ interface BuildCommand {
3434
*/
3535
async function runBuildCommand({command, config, watch}: BuildCommand) {
3636
const {count, filePaths, size, warnings} = await workboxBuild[command](
37-
config,
37+
config as any,
3838
);
3939

4040
for (const warning of warnings) {

0 commit comments

Comments
 (0)