Skip to content

Commit 102eaed

Browse files
fix: (appengine) update region tag in appengine/websockets/app.js & appengine/websockets/views/index.pug (#3956)
* fix: (appengine) update region tag in appengine/websockets/app.js * fix: (appengine) update region tag in appengine/websockets/views/index.pug * fix: (websockets) correct test name fromappengine_websockets_app to gae_websockets_app * added the appengine_websockets_app test --------- Co-authored-by: Jennifer Davis <[email protected]>
1 parent 8173aae commit 102eaed

File tree

3 files changed

+27
-0
lines changed

3 files changed

+27
-0
lines changed

appengine/websockets/app.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
'use strict';
1616

17+
// [START gae_websockets_app]
1718
// [START appengine_websockets_app]
1819
const app = require('express')();
1920
app.set('view engine', 'pug');
@@ -39,5 +40,6 @@ if (module === require.main) {
3940
});
4041
}
4142
// [END appengine_websockets_app]
43+
// [END gae_websockets_app]
4244

4345
module.exports = server;

appengine/websockets/test/index.test.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,22 @@ describe('appengine_websockets_app', () => {
5555
assert.strictEqual(itemText, 'test');
5656
});
5757
});
58+
59+
describe('gae_websockets_app', () => {
60+
it('should process chat message', async () => {
61+
await browserPage.goto('http://localhost:8080');
62+
63+
await browserPage.evaluate(() => {
64+
document.querySelector('input').value = 'test';
65+
document.querySelector('button').click();
66+
});
67+
68+
await new Promise(resolve => setTimeout(resolve, 100));
69+
70+
const itemText = await browserPage.evaluate(
71+
() => document.querySelector('li').textContent
72+
);
73+
74+
assert.strictEqual(itemText, 'test');
75+
});
76+
});

appengine/websockets/views/index.pug

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
//- See the License for the specific language governing permissions and
1313
//- limitations under the License.
1414
15+
//- [START gae_websockets_index]
1516
//- [START appengine_websockets_index]
1617
doctype html
1718
html(lang="en")
@@ -27,17 +28,20 @@ html(lang="en")
2728
#messages { list-style-type: none; margin: 0; padding: 0; }
2829
#messages li { padding: 5px 10px; }
2930
#messages li:nth-child(odd) { background: #eee; }
31+
//- [START gae_websockets_form]
3032
//- [START appengine_websockets_form]
3133
body
3234
ul(id="messages")
3335
form(action="")
3436
input(id="m" autocomplete="off")
3537
button Send
3638
//- [END appengine_websockets_form]
39+
//- [END gae_websockets_form]
3740
3841
script(src="/socket.io/socket.io.js")
3942
script(src="https://code.jquery.com/jquery-1.11.1.js")
4043
script.
44+
// [START gae_websockets_js]
4145
// [START appengine_websockets_js]
4246
$(function () {
4347
var socket = io();
@@ -54,5 +58,7 @@ html(lang="en")
5458
});
5559
});
5660
// [END appengine_websockets_js]
61+
// [END gae_websockets_js]
5762
//- [END appengine_websockets_index]
63+
//- [END gae_websockets_index]
5864

0 commit comments

Comments
 (0)