Skip to content

Commit 50b1ea8

Browse files
committed
Merge branch 'main' of github.com:GoogleCloudPlatform/nodejs-docs-samples into test-isolation-configs
2 parents df5ec73 + 37eec28 commit 50b1ea8

File tree

7 files changed

+21
-6
lines changed

7 files changed

+21
-6
lines changed

appengine/building-an-app/build/server.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
'use strict';
1616

17+
// [START gae_build_web_server_app]
1718
// [START app]
1819
// [START gae_app]
1920
const express = require('express');
@@ -30,5 +31,6 @@ app.listen(PORT, () => {
3031
});
3132
// [END gae_app]
3233
// [END app]
34+
// [END gae_build_web_server_app]
3335

3436
module.exports = app;

appengine/building-an-app/build/test/server.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,9 @@ describe('gae_app', () => {
2121
await supertest(app).get('/').expect(200);
2222
});
2323
})
24+
25+
describe('gae_build_web_server_app', () => {
26+
it('should be listening', async () => {
27+
await supertest(app).get('/').expect(200);
28+
});
29+
})

appengine/building-an-app/update/server.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
'use strict';
1616

17+
// [START gae_update_web_server_app]
1718
// [START app]
1819
// [START gae_update_app]
1920
const express = require('express');
@@ -59,5 +60,6 @@ app.listen(PORT, () => {
5960
});
6061
// [END gae_update_app]
6162
// [END app]
63+
// [END gae_update_web_server_app]
6264

6365
module.exports = app;

appengine/building-an-app/update/test/server.test.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,17 @@ describe('gae_update_app', () => {
4747
});
4848
});
4949

50+
describe('gae_update_web_server_app', () => {
51+
it('should send greetings', async () => {
52+
await requestObj
53+
.get('/')
54+
.expect(200)
55+
.expect(response => {
56+
assert.strictEqual(response.text, 'Hello from App Engine!');
57+
});
58+
});
59+
});
60+
5061
describe('gae_add_display_form add_display_form', () => {
5162
it('should display form', async () => {
5263
await requestObj

datacatalog/cloud-client/createFilesetEntry.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const main = async (
2727
entryId
2828
) => {
2929
// [START data_catalog_create_fileset]
30-
// [START datacatalog_create_fileset_tag]
3130
// -------------------------------
3231
// Import required modules.
3332
// -------------------------------
@@ -101,7 +100,6 @@ const main = async (
101100
const [response] = await datacatalog.createEntry(request);
102101

103102
console.log(response);
104-
// [END datacatalog_create_fileset_tag]
105103
// [END data_catalog_create_fileset]
106104
};
107105

datacatalog/cloud-client/lookupEntry.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
*/
2424
const main = async (projectId, datasetId) => {
2525
// [START data_catalog_lookup_dataset]
26-
// [START datacatalog_lookup_dataset]
2726
// -------------------------------
2827
// Import required modules.
2928
// -------------------------------
@@ -42,7 +41,6 @@ const main = async (projectId, datasetId) => {
4241

4342
const response = await lookup();
4443
console.log(response);
45-
// [END datacatalog_lookup_dataset]
4644
// [END data_catalog_lookup_dataset]
4745
};
4846

datacatalog/quickstart/createFilesetEntry.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const main = async (
2727
entryId
2828
) => {
2929
// [START data_catalog_create_fileset_quickstart]
30-
// [START datacatalog_create_fileset_quickstart_tag]
3130
// -------------------------------
3231
// Import required modules.
3332
// -------------------------------
@@ -125,7 +124,6 @@ const main = async (
125124

126125
console.log(response);
127126
};
128-
// [END datacatalog_create_fileset_quickstart_tag]
129127
// [END data_catalog_create_fileset_quickstart]
130128

131129
// node createFilesetEntry.js <projectId> <entryGroupId> <entryId>

0 commit comments

Comments
 (0)