Skip to content

Commit 63bc5f0

Browse files
authored
fix: add id-token to workflows (#4063)
* feat: support testing on forked repos * add pull_request to test on PR * remove prod suffix * decode json on matrix paths * add experimental to check names * add experimental to job names * run test only if paths is not empty * test explicitly against empty array * move experimental as a prefix * success check if no paths are found * always set check to done * remove pull_request trigger * rearrange if check * add more comments * fix: add id-token to workflows
1 parent 0e0c99b commit 63bc5f0

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

.github/workflows/custard-run-dev.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ jobs:
6161
runs-on: ubuntu-latest
6262
timeout-minutes: 120 # 2 hours hard limit
6363
permissions:
64+
id-token: write
6465
statuses: write
6566
strategy:
6667
fail-fast: false
@@ -108,13 +109,6 @@ jobs:
108109
with:
109110
check: ${{ steps.in_progress.outputs.check }}
110111
status: failure
111-
# - name: Upload test results for FlakyBot workflow
112-
# if: github.event.action == 'schedule' && always() # always() submits logs even if tests fail
113-
# uses: actions/upload-artifact@v4
114-
# with:
115-
# name: test-results
116-
# path: ${{ matrix.path }}/${{ github.run_id }}_sponge_log.xml
117-
# retention-days: 1
118112

119113
done:
120114
needs: [affected, test]

.github/workflows/custard-run.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ jobs:
105105
runs-on: ubuntu-latest
106106
timeout-minutes: 120 # 2 hours hard limit
107107
permissions:
108+
id-token: write
108109
statuses: write
109110
strategy:
110111
fail-fast: false
@@ -152,13 +153,6 @@ jobs:
152153
with:
153154
check: ${{ steps.in_progress.outputs.check }}
154155
status: failure
155-
# - name: Upload test results for FlakyBot workflow
156-
# if: github.event.action == 'schedule' && always() # always() submits logs even if tests fail
157-
# uses: actions/upload-artifact@v4
158-
# with:
159-
# name: test-results
160-
# path: ${{ matrix.path }}/${{ github.run_id }}_sponge_log.xml
161-
# retention-days: 1
162156

163157
done:
164158
needs: [affected, lint, test]

0 commit comments

Comments
 (0)