Changes after review

Author: Joanna Grycz

batch/create/create_batch_labels_runnable.js

@@ -32,18 +32,18 @@ async function main() {
   const projectId = await batchClient.getProjectId();
   // Name of the region you want to use to run the job. Regions that are
   // available for Batch are listed on: https://cloud.google.com/batch/docs/get-started#locations
-  const region = 'europe-central2';
+  const region = 'us-central1';
   // The name of the job that will be created.
   // It needs to be unique for each project and region pair.
-  const jobName = 'batch-labels-runnable';
+  const jobName = 'example-job';
   // Name of the label1 to be applied for your Job.
-  const labelName1 = 'runnable_label_name_1';
+  const labelName1 = 'RUNNABLE_LABEL_NAME1';
   // Value for the label1 to be applied for your Job.
-  const labelValue1 = 'runnable_label_value1';
+  const labelValue1 = 'RUNNABLE_LABEL_VALUE1';
   // Name of the label2 to be applied for your Job.
-  const labelName2 = 'runnable_label_name_2';
+  const labelName2 = 'RUNNABLE_LABEL_NAME2';
   // Value for the label2 to be applied for your Job.
-  const labelValue2 = 'runnable_label_value2';
+  const labelValue2 = 'RUNNABLE_LABEL_VALUE2';
 
   const container = new batch.Runnable.Container({
     imageUri: 'gcr.io/google-containers/busybox',

batch/test/create_batch_labels_runnable.test.js

@@ -27,30 +27,30 @@ const {deleteJob} = require('./batchClient_operations');
 const batchClient = new BatchServiceClient();
 
 describe('Create batch labels runnable', async () => {
-  const runnableName = 'batch-labels-runnable';
-  const region = 'europe-central2';
+  const jobName = 'example-job';
+  const region = 'us-central1';
   let projectId;
 
   before(async () => {
     projectId = await batchClient.getProjectId();
   });
 
   after(async () => {
-    await deleteJob(batchClient, projectId, region, runnableName);
+    await deleteJob(batchClient, projectId, region, jobName);
   });
 
   it('should create a new job with labels for runnables', async () => {
     const expectedRunnableLabels = [
       {
         executable: 'container',
         labels: {
-          runnable_label_name_1: 'runnable_label_value1',
+          RUNNABLE_LABEL_NAME1: 'RUNNABLE_LABEL_VALUE1',
         },
       },
       {
         executable: 'script',
         labels: {
-          runnable_label_name_2: 'runnable_label_value2',
+          RUNNABLE_LABEL_NAME2: 'RUNNABLE_LABEL_VALUE2',
         },
       },
     ];