fix: remove unused error concepts function snippets (#3669)

* fix: remove unused error concepts function snippets

* fix: cleaning up lint

* fix: moving region tag to not include the ending }

* fix: more linting issues

Author: iennae

functions/helloworld/helloError/index.js

@@ -14,8 +14,6 @@
 
 'use strict';
 
-const functions = require('@google-cloud/functions-framework');
-
 /* eslint-disable no-unused-vars */
 
 /**
@@ -32,41 +30,3 @@ exports.helloError = (event, context, callback) => {
   throw new Error('I failed you'); // Will cause a cold start if not caught
   // [END functions_helloworld_error]
 };
-
-/**
- * Background Cloud Function that throws a value.
- *
- * @param {object} event The Cloud Functions event.
- * @param {object} context The event metadata.
- * @param {function} callback The callback function.
- */
-exports.helloError2 = (event, context, callback) => {
-  // [START functions_helloworld_error_2]
-  // These WILL be reported to Error Reporting
-  console.error(new Error('I failed you')); // Logging an Error object
-  console.error('I failed you'); // Logging something other than an Error object
-  throw 1; // Throwing something other than an Error object
-  // [END functions_helloworld_error_2]
-};
-
-/**
- * Background Cloud Function that returns an error.
- *
- * @param {object} event The Cloud Functions event.
- * @param {object} context The event metadata.
- * @param {function} callback The callback function.
- */
-exports.helloError3 = (event, context, callback) => {
-  // [START functions_helloworld_error_3]
-  // This will NOT be reported to Error Reporting
-  callback('I failed you');
-  // [END functions_helloworld_error_3]
-};
-
-// HTTP Cloud Function that returns an error.
-functions.http('helloError4', (req, res) => {
-  // [START functions_helloworld_error_4]
-  // This will NOT be reported to Error Reporting
-  res.status(500).send('I failed you');
-  // [END functions_helloworld_error_4]
-});

functions/helloworld/helloError/test/index.test.js

@@ -13,8 +13,6 @@
 // limitations under the License.
 
 const assert = require('assert');
-const sinon = require('sinon');
-
 const program = require('..');
 
 describe('index.test.js', () => {
@@ -25,23 +23,4 @@ describe('index.test.js', () => {
       });
     });
   });
-
-  describe('functions_helloworld_error_2', () => {
-    describe('Error handling (unit tests)', () => {
-      it('helloError2: should throw a value', () => {
-        assert.throws(program.helloError2, '1');
-      });
-    });
-  });
-
-  describe('functions_helloworld_error_3', () => {
-    describe('Error handling (unit tests)', () => {
-      it('helloError3: callback should return an errback value', () => {
-        const cb = sinon.stub();
-        program.helloError3(null, null, cb);
-        assert.ok(cb.calledOnce);
-        assert.ok(cb.calledWith('I failed you'));
-      });
-    });
-  });
 });