From 65c3c8e0139e245533c798d60b205ee980cdba74 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Wed, 22 Jan 2025 20:16:56 +0000 Subject: [PATCH 01/10] fix: (data_catalog) delete deprecated region tag in createFilesettEntry.js --- datacatalog/cloud-client/createFilesetEntry.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/datacatalog/cloud-client/createFilesetEntry.js b/datacatalog/cloud-client/createFilesetEntry.js index 2561c6a27b..908b7c7b69 100644 --- a/datacatalog/cloud-client/createFilesetEntry.js +++ b/datacatalog/cloud-client/createFilesetEntry.js @@ -27,11 +27,10 @@ const main = async ( entryId ) => { // [START data_catalog_create_fileset] - // [START datacatalog_create_fileset_tag] // ------------------------------- // Import required modules. // ------------------------------- - const {DataCatalogClient} = require('@google-cloud/datacatalog').v1; + const { DataCatalogClient } = require('@google-cloud/datacatalog').v1; const datacatalog = new DataCatalogClient(); // Currently, Data Catalog stores metadata in the @@ -50,7 +49,7 @@ const main = async ( const entry = { displayName: 'My Fileset', description: 'This fileset consists of ....', - gcsFilesetSpec: {filePatterns: ['gs://my_bucket/*']}, + gcsFilesetSpec: { filePatterns: ['gs://my_bucket/*'] }, schema: { columns: [ { @@ -101,7 +100,6 @@ const main = async ( const [response] = await datacatalog.createEntry(request); console.log(response); - // [END datacatalog_create_fileset_tag] // [END data_catalog_create_fileset] }; From 8e2456d9ad2b3ae17b275a8d6a5d7645fa4dfef7 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Wed, 22 Jan 2025 20:17:38 +0000 Subject: [PATCH 02/10] fix: (data_catalog) delete deprecated region tag in quickstart/createFilesettEntry.js --- datacatalog/quickstart/createFilesetEntry.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/datacatalog/quickstart/createFilesetEntry.js b/datacatalog/quickstart/createFilesetEntry.js index b178906863..33b0b0b92f 100644 --- a/datacatalog/quickstart/createFilesetEntry.js +++ b/datacatalog/quickstart/createFilesetEntry.js @@ -27,11 +27,10 @@ const main = async ( entryId ) => { // [START data_catalog_create_fileset_quickstart] - // [START datacatalog_create_fileset_quickstart_tag] // ------------------------------- // Import required modules. // ------------------------------- - const {DataCatalogClient} = require('@google-cloud/datacatalog').v1; + const { DataCatalogClient } = require('@google-cloud/datacatalog').v1; const datacatalog = new DataCatalogClient(); // ------------------------------- @@ -73,7 +72,7 @@ const main = async ( const entry = { displayName: 'My Fileset', description: 'This fileset consists of ...', - gcsFilesetSpec: {filePatterns: ['gs://my_bucket/*']}, + gcsFilesetSpec: { filePatterns: ['gs://my_bucket/*'] }, schema: { columns: [ { @@ -125,7 +124,6 @@ const main = async ( console.log(response); }; -// [END datacatalog_create_fileset_quickstart_tag] // [END data_catalog_create_fileset_quickstart] // node createFilesetEntry.js From e8bf288d35930c195e322e460a2a08901ade8f66 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 15:10:51 +0000 Subject: [PATCH 03/10] fix: (appengine) update region tag in appengine/websockets/app.yaml --- appengine/websockets/app.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 78189a14fe..291dd5b253 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -1,4 +1,4 @@ -# [START appengine_websockets_yaml] +# [START gae_websockets_yaml] runtime: nodejs env: flex @@ -10,5 +10,5 @@ manual_scaling: network: session_affinity: true -# [END appengine_websockets_yaml] +# [END gae_websockets_yaml] From 01ba935d47b5ceb91dc58849d910f6b435a5774c Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 15:13:31 +0000 Subject: [PATCH 04/10] fix linting issues --- datacatalog/cloud-client/createFilesetEntry.js | 4 ++-- datacatalog/quickstart/createFilesetEntry.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/datacatalog/cloud-client/createFilesetEntry.js b/datacatalog/cloud-client/createFilesetEntry.js index 908b7c7b69..efbdea5c66 100644 --- a/datacatalog/cloud-client/createFilesetEntry.js +++ b/datacatalog/cloud-client/createFilesetEntry.js @@ -30,7 +30,7 @@ const main = async ( // ------------------------------- // Import required modules. // ------------------------------- - const { DataCatalogClient } = require('@google-cloud/datacatalog').v1; + const {DataCatalogClient} = require('@google-cloud/datacatalog').v1; const datacatalog = new DataCatalogClient(); // Currently, Data Catalog stores metadata in the @@ -49,7 +49,7 @@ const main = async ( const entry = { displayName: 'My Fileset', description: 'This fileset consists of ....', - gcsFilesetSpec: { filePatterns: ['gs://my_bucket/*'] }, + gcsFilesetSpec: {filePatterns: ['gs://my_bucket/*']}, schema: { columns: [ { diff --git a/datacatalog/quickstart/createFilesetEntry.js b/datacatalog/quickstart/createFilesetEntry.js index 33b0b0b92f..87dd94e265 100644 --- a/datacatalog/quickstart/createFilesetEntry.js +++ b/datacatalog/quickstart/createFilesetEntry.js @@ -30,7 +30,7 @@ const main = async ( // ------------------------------- // Import required modules. // ------------------------------- - const { DataCatalogClient } = require('@google-cloud/datacatalog').v1; + const {DataCatalogClient} = require('@google-cloud/datacatalog').v1; const datacatalog = new DataCatalogClient(); // ------------------------------- @@ -72,7 +72,7 @@ const main = async ( const entry = { displayName: 'My Fileset', description: 'This fileset consists of ...', - gcsFilesetSpec: { filePatterns: ['gs://my_bucket/*'] }, + gcsFilesetSpec: {filePatterns: ['gs://my_bucket/*']}, schema: { columns: [ { From 9ee1b13d376960e7b7977afb8137d94620113f91 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 18:44:05 +0000 Subject: [PATCH 05/10] added license header to appengine/websockets/app.yaml file --- appengine/websockets/app.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 291dd5b253..39c73a4638 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -1,3 +1,16 @@ +# Copyright 2015-2016, Google, Inc. +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + # [START gae_websockets_yaml] runtime: nodejs env: flex From 3369b83ec3dbc35d8e3c0ff6ef3d1986da338076 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 18:46:35 +0000 Subject: [PATCH 06/10] update license header to appengine/websockets/app.yaml file --- appengine/websockets/app.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 39c73a4638..74a141a093 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -1,9 +1,10 @@ -# Copyright 2015-2016, Google, Inc. +# Copyright 2025 Google LLC +# # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, From f48277c033c0c8206d93663480d5285c576d7375 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 18:50:39 +0000 Subject: [PATCH 07/10] fix region tag name --- appengine/websockets/app.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 74a141a093..90c2d807f2 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# [START gae_websockets_yaml] +# [START gae_websockets_nodejs_yaml] runtime: nodejs env: flex @@ -24,5 +24,5 @@ manual_scaling: network: session_affinity: true -# [END gae_websockets_yaml] +# [END gae_websockets_nodejs_yaml] From 18bdc26b648b37732f3ad7809a7903d12ca039cb Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Thu, 23 Jan 2025 18:52:57 +0000 Subject: [PATCH 08/10] fix region tag name --- appengine/websockets/app.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 90c2d807f2..2f48b8c3b9 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# [START gae_websockets_nodejs_yaml] +# [START gae_websockets_yaml_nodejs] runtime: nodejs env: flex @@ -24,5 +24,5 @@ manual_scaling: network: session_affinity: true -# [END gae_websockets_nodejs_yaml] +# [END gae_websockets_yaml_nodejs] From 4a89d51287dac0e19cb4619886e298aa5acc1252 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Mon, 27 Jan 2025 17:16:43 +0000 Subject: [PATCH 09/10] chore: update copyright year format to include start year --- appengine/websockets/app.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 2f48b8c3b9..469a57e4af 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -1,4 +1,4 @@ -# Copyright 2025 Google LLC +# Copyright 2018-2025 Google LLC # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. From 2ad56c87c3ab951593738dc621c294ae50c1a312 Mon Sep 17 00:00:00 2001 From: Jennifer Davis Date: Mon, 27 Jan 2025 12:44:38 -0800 Subject: [PATCH 10/10] fix: year needs to be the initial year not a range --- appengine/websockets/app.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/websockets/app.yaml b/appengine/websockets/app.yaml index 469a57e4af..0256039dfb 100644 --- a/appengine/websockets/app.yaml +++ b/appengine/websockets/app.yaml @@ -1,4 +1,4 @@ -# Copyright 2018-2025 Google LLC +# Copyright 2018 Google LLC # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License.