scenarios are not persisted correctly to/read from XLS template

[okworx]

Test case:

• create new EPD dataset

• choose EF3.1 profile

• create scenarios "100% incineration" and "100% recycling", leaving group empty, selecting the former as default
  

• add modules for both scenarios
  

• synchronize results table

• export results table to XLS template

• add some test numbers to XLS template:
  results_EF3.1_dual_scenario.xlsx

• create new EPD dataset

• import XLS template

Observed behavior:

• there are duplicate entries in the scenarios list
• the default status is not restored
  

Expected behavior:

• only two scenarios are in the scenarios list
• the default status is restored ("100% incineration" marked as default)
• bonus: the correct profile is being picked up and reflected in the profile drop-down

The same behavior can be observed when explicitly assigning a group ID. When adding another scenario group and using explicit group IDs, the group IDs and default status is lost as well (example XLS template: results_EF3.1_quad_scenario.xlsx)

In general, all declared scenarios without a group ID should be treated as belonging to the same group.

[msrocka]

@okworx I created a pre-release where I tried to solve this: https://github.com/GreenDelta/epd-editor/releases/tag/v6.0.3

[okworx]

@okworx I created a pre-release where I tried to solve this: https://github.com/GreenDelta/epd-editor/releases/tag/v6.0.3

Awesome, thanks! Will there be a macOS build too for testing?

[msrocka]

@francoislerall could you make a test build for macOS?

[francoislerall]

@francoislerall could you make a test build for macOS?

Yes, today or tomorrow

[francoislerall]

I have added a macOS build :)

[okworx]

Thank you guys for the fix and the new build!

While this works in principle, it will not work anymore when people use slashes for scenario names, which eventually someone will. Consider this case:

Exporting and re-importing the XLSX template for this example will not work.

Therefore, I suggest using something as a separator which is more unlikely to be used in names. How about three slashes, for example ///? Or maybe you've got a better idea.

[msrocka]

True, an alternative would be to only split the {module} / {scenario} identifier once after the first / for now.

[okworx]

Is there any chance to implement this in order to have this issue fully fixed and publish a new release?