update msg length (#600)

* update msg length * fix offset * fix pubkey len * fix sig * fix decoder * fix docs build * revert encdata change * bump to v3.4.0
GridPlus · Feb 7, 2025 · 8499560 · 8499560
1 parent 943f87b
commit 8499560
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/docs-build-deploy.yml b/.github/workflows/docs-build-deploy.yml
@@ -33,7 +33,7 @@ jobs:
         working-directory: ./docs
 
       - name: Upload production-ready build files
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: production-files
           path: docs/build
@@ -46,7 +46,7 @@ jobs:
 
     steps:
       - name: Download artifact
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: production-files
           path: docs/build

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gridplus-sdk",
-  "version": "3.3.0",
+  "version": "3.4.0",
   "type": "module",
   "description": "SDK to interact with GridPlus Lattice1 device",
   "scripts": {

diff --git a/src/__test__/unit/__snapshots__/decoders.test.ts.snap b/src/__test__/unit/__snapshots__/decoders.test.ts.snap
@@ -3529,8 +3529,8 @@ exports[`decoders > sign - bitcoin 1`] = `
       "type": "Buffer",
     },
   ],
-  "tx": "0200000000010135fa06fcfd26567f9d8f57073c34705df0a69339ce717654bcd24033dddbefb20000000000ffffffff02701101000000000017a9147d816ef0a39d6497963ebcf24d05242d51ada7438774090000000000001600146bb07ddb748b655c8478581af3e128335c16eca00248304502210084e356184a7dc1e05a08808cb6da03f9e5d1c37be0f382a761eac2a266a4737f0220172d99b82cf78bf5bb4299e4e663f13e1e4578d144ffeabc474631fb1ac1a4fe0121000000000000000000000000000000000000000002d423e4c1cc57744a0e73659500000000",
-  "txHash": "cc9f6840abe1ef0b2b106ebc5d87c8b013d42060da91cfeae1f7ce3b71638458",
+  "tx": "0200000000010135fa06fcfd26567f9d8f57073c34705df0a69339ce717654bcd24033dddbefb20000000000ffffffff02701101000000000017a9147d816ef0a39d6497963ebcf24d05242d51ada7438774090000000000001600146bb07ddb748b655c8478581af3e128335c16eca00248304502210084e356184a7dc1e05a08808cb6da03f9e5d1c37be0f382a761eac2a266a4737f0220172d99b82cf78bf5bb4299e4e663f13e1e4578d144ffeabc474631fb1ac1a4fe012102d423e4c1cc57744a0e7365954e7a632ab272f5d0167337f69227c58e6e2d113e00000000",
+  "txHash": "e5e2c39d225a689a46d5cb8b9f1eb3efa94d532ae65ac78dd54c6d7212268dbf",
 }
 `;
 

diff --git a/src/functions/sign.ts b/src/functions/sign.ts
@@ -148,7 +148,7 @@ export const decodeSignResponse = ({
   if (currency === CURRENCIES.BTC) {
     const btcRequest = request as BitcoinSignRequest;
     const pkhLen = 20; // Pubkeyhashes are 20 bytes
-    const sigsLen = 740; // Up to 10x DER signatures
+    const sigsLen = 760; // Up to 10x DER signatures
     const changeVersion = bitcoin.getAddressFormat(
       btcRequest.origData.changePath,
     );