Don't store Buddy and PokemonDetail protos (#822)

Author: Gegy

library/src/main/java/com/pokegoapi/api/PokemonGo.java

@@ -190,6 +190,7 @@ public void login(CredentialProvider credentialProvider)
 		inventories = new Inventories(this);
 		settings = new Settings(this);
 		playerProfile = new PlayerProfile(this);
+		playerProfile.updateProfile();
 
 		initialize();
 

library/src/main/java/com/pokegoapi/api/map/Point.java

@@ -42,6 +42,10 @@ public Point(SpawnPointOuterClass.SpawnPoint spawnpoint) {
 
 	@Override
 	public String toString() {
-		return this.latitude + ", " + this.longitude;
+		StringBuilder builder = new StringBuilder();
+		builder.append(this.latitude);
+		builder.append(", ");
+		builder.append(this.longitude);
+		return builder.toString();
 	}
 }

library/src/main/java/com/pokegoapi/api/player/PlayerProfile.java

@@ -104,10 +104,6 @@ public class PlayerProfile {
 	public PlayerProfile(PokemonGo api) throws LoginFailedException, CaptchaActiveException, RemoteServerException {
 		this.api = api;
 		this.playerLocale = new PlayerLocale();
-
-		if (playerData == null) {
-			updateProfile();
-		}
 	}
 
 	/**

library/src/main/java/com/pokegoapi/api/pokemon/Buddy.java

@@ -20,7 +20,9 @@
 
 public class Buddy {
 	private final PokemonGo api;
-	private final BuddyPokemon proto;
+	private long id;
+	private double lastKMAwarded;
+	private double startKM;
 	private Pokemon pokemon;
 	private double buddyDistance;
 
@@ -31,15 +33,17 @@ public class Buddy {
 	 */
 	public Buddy(PokemonGo api, BuddyPokemon proto) {
 		this.api = api;
-		this.proto = proto;
+		this.id = proto.getId();
+		this.lastKMAwarded = proto.getLastKmAwarded();
+		this.startKM = proto.getStartKmWalked();
 	}
 
 	/**
 	 * @return the pokemon object of this buddy
 	 */
 	public Pokemon getPokemon() {
 		if (pokemon == null) {
-			pokemon = api.getInventories().getPokebank().getPokemonById(proto.getId());
+			pokemon = api.getInventories().getPokebank().getPokemonById(this.id);
 			buddyDistance = PokemonMetaRegistry.getMeta(pokemon.getPokemonId()).getBuddyDistance();
 		}
 		return pokemon;
@@ -59,14 +63,14 @@ public double getBuddyDistance() {
 	 * @return the last walk distance when a candy was received
 	 */
 	public double getLastReceiveKM() {
-		return proto.getLastKmAwarded();
+		return lastKMAwarded;
 	}
 
 	/**
 	 * @return the distance when the distance started progressing
 	 */
 	public double getStartKM() {
-		return proto.getStartKmWalked();
+		return startKM;
 	}
 
 	/**

library/src/main/java/com/pokegoapi/api/pokemon/Pokemon.java

@@ -238,7 +238,7 @@ public UpgradePokemonResponse.Result call(ByteString result) {
 							throw new AsyncRemoteServerException(e);
 						}
 						//set new pokemon details
-						setProto(response.getUpgradedPokemon());
+						applyProto(response.getUpgradedPokemon());
 						return response.getResult();
 					}
 				});