Lazy use aws sdk to avoid crashing version check when env vars are missing (#20)

* lazy intialize the aws sdk

* lazy loading the otel sdk to be consistent

* create a new release

Author: Grunet

.github/workflows/ci.yaml

@@ -19,7 +19,3 @@ jobs:
       - name: Run CI
         run: |
           make ci
-        env:
-          #CI as of right now doesn't exercise the aws sdk fork
-          #So setting this so it doesn't throw an error here - https://github.com/christophgysin/aws-sdk-js-v3/blob/deno/deno/config-resolver/regionConfig/resolveRegionConfig.ts#L23
-          AWS_DEFAULT_REGION: "unused"

src/index.ts

@@ -15,12 +15,16 @@ const cliArgs = parse(Deno.args);
 await invoke({
   cliArgs: cliArgs as IExpectedCliArgs,
   versionData: versionDataFromFile as IVersionData,
-  cloudformationClientAdapter: createCloudformationClientAdapter({
-    accessKeyId: Deno.env.get("AWS_ACCESS_KEY_ID") ?? "", //TODO - add more explicit validation for these
-    secretAccessKey: Deno.env.get("AWS_SECRET_ACCESS_KEY") ?? "",
-    region: Deno.env.get("AWS_DEFAULT_REGION") ?? "",
-  }),
+  cloudformationClientAdapterFactory: () => {
+    return createCloudformationClientAdapter({
+      accessKeyId: Deno.env.get("AWS_ACCESS_KEY_ID") ?? "", //TODO - add more explicit validation for these
+      secretAccessKey: Deno.env.get("AWS_SECRET_ACCESS_KEY") ?? "",
+      region: Deno.env.get("AWS_DEFAULT_REGION") ?? "",
+    });
+  },
   transformStackEventDataIntoTracingData,
-  telemetrySender: createTelemetrySender(),
+  telemetrySenderFactory: () => {
+    return createTelemetrySender();
+  },
   logger: console,
 });

src/invoke.ts

@@ -9,10 +9,10 @@ import { ITelemetrySender } from "./openTelemetryAdapter/sender.ts";
 interface IInputs {
   cliArgs: IExpectedCliArgs;
   versionData: IVersionData;
-  cloudformationClientAdapter: ICloudformationClientAdapter;
+  cloudformationClientAdapterFactory: () => ICloudformationClientAdapter;
   transformStackEventDataIntoTracingData:
     typeof transformStackEventDataIntoTracingData;
-  telemetrySender: ITelemetrySender;
+  telemetrySenderFactory: () => ITelemetrySender;
   logger: ILogger;
 }
 
@@ -33,9 +33,9 @@ async function invoke(
   {
     cliArgs, //TODO - validate this input with zod, iots, etc...
     versionData,
-    cloudformationClientAdapter,
+    cloudformationClientAdapterFactory,
     transformStackEventDataIntoTracingData,
-    telemetrySender,
+    telemetrySenderFactory,
     logger,
   }: IInputs,
 ) {
@@ -47,11 +47,11 @@ async function invoke(
     const tracingData = await transformStackEventDataIntoTracingData({
       stackName: cliArgs["stack-name"],
       dependencies: {
-        cloudformationClientAdapter,
+        cloudformationClientAdapter: cloudformationClientAdapterFactory(),
       },
     });
 
-    await telemetrySender.sendTracingData(tracingData);
+    await telemetrySenderFactory().sendTracingData(tracingData);
   }
 }
 

src/invoke_test.ts

@@ -33,14 +33,22 @@ Deno.test("Passing --version logs the version to the console", async () => {
   await invoke({
     cliArgs: parsedCliArgs,
     versionData: mockVersionData,
-    cloudformationClientAdapter: {
+    cloudformationClientAdapterFactory: () => ({
       getEventsFromMostRecentDeploy() {
         return Promise.resolve({ stackEvents: [] });
       },
-    },
+    }),
     transformStackEventDataIntoTracingData: () => {
-      return Promise.resolve({ spanDataByConstructedId: new Map() });
+      return Promise.resolve({
+        spanDataByConstructedId: new Map(),
+        rootConstructedId: "",
+      });
     },
+    telemetrySenderFactory: () => ({
+      sendTracingData() {
+        return Promise.resolve();
+      },
+    }),
     logger: mockLogger,
   });
 

version.json

@@ -1,3 +1,3 @@
 {
-  "version": "0.0.5"
+  "version": "0.0.6"
 }