Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons to SVG #2

Open
GuilhermeBalog opened this issue Dec 11, 2022 · 0 comments
Open

Change icons to SVG #2

GuilhermeBalog opened this issue Dec 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@GuilhermeBalog
Copy link
Owner

Currently the page is using font-awesome icons as a font and I think it's worthy to change to SVG icons.

The page has to download the whole font-awesome's css (with icons that are not used) and 2 different font files, which can not be gziped, since they are binary files.

image

Maybe changing to SVG files will be better. Usually the drawback of using SVG is that you cannot change its color (when loaded via <img /> tag), but in this page the colors are not dynamic.

I don't know if it's better to inline the SVGs or load them via <img /> tags, but I believe that in both cases it would be better than load the whole css file + two 80kb binary files.

@GuilhermeBalog GuilhermeBalog added the enhancement New feature or request label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant