Skip to content

Commit 3efb8ee

Browse files
committed
Fix messaging
1 parent 3036df5 commit 3efb8ee

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/ar_query_matchers.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,9 @@ def filter_model_names(subset, show_values, ignore_missing)
401401

402402
def expectation_failed_message(crud_operation, show_values: false, subset: false, ignore_missing: false)
403403
model_names_with_wrong_count = filter_model_names(subset, show_values, ignore_missing)
404-
"Expected ActiveRecord to #{crud_operation} #{expected}, got #{show_values ? @query_stats.query_values : @query_stats.query_counts}\n"\
405-
"Expectations that differed:\n#{difference(model_names_with_wrong_count, show_values: show_values).join("\n")}\n\nWhere unexpected queries came from:\n\n#{source_lines(model_names_with_wrong_count).join("\n")}"
404+
message = "Expected ActiveRecord to #{crud_operation} #{expected}, got #{show_values ? @query_stats.query_values : @query_stats.query_counts}\n"
405+
message += "Expectations that differed:\n#{difference(model_names_with_wrong_count, show_values: show_values).join("\n")}" if show_values
406+
message += "\n\nWhere unexpected queries came from:\n\n#{source_lines(model_names_with_wrong_count).join("\n")}"
406407
end
407408
end
408409
end

0 commit comments

Comments
 (0)