Skip to content

Commit 799b6ea

Browse files
committed
tests: change ConnectTimeout to ConnectionError
* Also add quotes to "pip install" command in README.md.
1 parent 39b3891 commit 799b6ea

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ $ git clone https://github.com/HEPData/hepdata-cli.git
4141
$ cd hepdata-cli
4242
$ python3 -m venv ~/venv/hepdata-cli
4343
$ source ~/venv/hepdata-cli/bin/activate
44-
(hepdata-cli) $ pip install -e .[tests]
44+
(hepdata-cli) $ pip install -e '.[tests]'
4545
(hepdata-cli) $ hepdata-cli --help
4646
(hepdata-cli) $ pytest --cov=hepdata_cli
4747
```

tests/test_resilient_requests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ def test_timeout():
1212
adapter = TimeoutHTTPAdapter(max_retries=retry_strategy, timeout=0.0001)
1313
with requests.Session() as session:
1414
session.mount("https://", adapter)
15-
with pytest.raises(requests.exceptions.ConnectTimeout):
15+
with pytest.raises(requests.exceptions.ConnectionError):
1616
session.get(SITE_URL + '/ping')

0 commit comments

Comments
 (0)