Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify backend environment variables and routes #72

Open
3 tasks
jasalisbury opened this issue Sep 30, 2020 · 2 comments
Open
3 tasks

Clarify backend environment variables and routes #72

jasalisbury opened this issue Sep 30, 2020 · 2 comments
Labels
enhancement New feature or request In epic 8 Issue is a child in the indicated parent epic JIRA Post MVP Issues cut from the MVP scope

Comments

@jasalisbury
Copy link
Contributor

This is a tech debt/technical ticket.

#4 enabled users to login and logout of the TTA Smart Hub. In this ticket a new environment variable was added, TTA_SMART_HUB_URI. My plan was for this variable to eventually replace REDIRECT_URI_HOST since they are the same value in most cases. The only place they are not the same is in local development. I thought we were going to be able to update the HSES callback to localhost:3000... but it has to stay localhost:8080..., which throws a wrench in my plan.

#4 also prepended api routes with /api. It would be nice if we can update our HSES callbacks to include /api in their paths to simplify the backend code.

We need to take some time to think about the environment variables and how we can change the HSES callback. Some options to start thinking about:

  • Swap the ports on the backend (currently 8080) and frontend (currently 3000) and remove the REDIRECT_URI_HOST environment variable
  • Keep both the REDIRECT_URI_HOST and TTA_SMART_HUB_URI variables
  • Something else I haven't thought of

Questions

Can we update the HSES callback adding api (and potentially v1) to the path? I.E. http://localhost:8080/api/v1/oauth2-client/login/oauth2/code/

Acceptance Criteria

  • All TODOs that deal with REDIRECT_URI_HOST are removed from the backend
  • It is clear what each environment variable is doing with as little overlap as possible
  • If possible, all API routes on the backend use the same router
@pamlo412 pamlo412 added enhancement New feature or request In epic 8 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Oct 31, 2020
rahearn pushed a commit that referenced this issue Nov 23, 2020
* add service instance

* add binding

* correct service binding

* add bucket to sand, stag, prod

* take out rds bind

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
@pamlo412
Copy link
Contributor

Per discussion at standup grooming, @jasalisbury wants to review/update this issue before we groom and prioritize it.

@jasalisbury
Copy link
Contributor Author

After reading this ticket after standup yesterday I think it is good to discuss as is.

@marriej marriej added the Post MVP Issues cut from the MVP scope label Feb 22, 2021
@marriej marriej added JIRA and removed V1.0 MVP Indicates the release version for the issue labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In epic 8 Issue is a child in the indicated parent epic JIRA Post MVP Issues cut from the MVP scope
Projects
None yet
Development

No branches or pull requests

3 participants