Skip to content

refactor: use has_proc_shop_change attribute #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor: use has_proc_shop_change attribute #4285

wants to merge 5 commits into from

Conversation

@fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Aug 29, 2025 •
edited
Loading

but will need more BE support based on
#4280 (comment)

What changed

Described what changes in this PR, at a high level

Issue

How to test

Write out steps for how someone could test this PR against the acceptance criteria

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

If relevant, e.g. for a link to a piece of markdown documentation

@fpigeonjr
feat: checks new attribute on change requests
838587f 
but will need more BE support based on
#4280 (comment)
@fpigeonjr fpigeonjr self-assigned this Aug 29, 2025
@fpigeonjr fpigeonjr changed the title refactor: use change request attribute refactor: use has_proc_shop_change attribute Aug 29, 2025
@fpigeonjr fpigeonjr added the Blocked More information, decisions, or actions by an external party are needed by to continue label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johndeange johndeange Awaiting requested review from johndeange johndeange will be requested when the pull request is marked ready for review johndeange is a code owner

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90 rajohnson90 will be requested when the pull request is marked ready for review rajohnson90 is a code owner

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd Santi-3rd will be requested when the pull request is marked ready for review Santi-3rd is a code owner

@weimiao67 weimiao67 Awaiting requested review from weimiao67 weimiao67 will be requested when the pull request is marked ready for review weimiao67 is a code owner

@josbell josbell Awaiting requested review from josbell josbell will be requested when the pull request is marked ready for review josbell is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@fpigeonjr fpigeonjr

Labels

Blocked More information, decisions, or actions by an external party are needed by to continue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI: update proc_shop change requests to use the new prop from api

2 participants

@fpigeonjr