Fix Portfolio Spending BLI Table and Loading MSG when switching tabs #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
josbell
requested review from
Santi-3rd,
fpigeonjr,
johndeange,
rajohnson90 and
weimiao67
as code owners
josbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Portfolio Spending view is now fetching BLIs associated with active AND inactive CANs. Portfolio Funding is still only fetching and rendering BLIs for active CANs. The API used for Fetching CANs for Portfolio Details page now accepts an optional query param that will skip the filtering out of inactive CANs.
Additionally the loading msg now renders correctly when switching between portfolio spending and portfolio funding tabs.
Issue
4578
How to test
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist
Links
If relevant, e.g. for a link to a piece of markdown documentation