Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3967 Adds New Storybook Navigation Structure #4040

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

KeithNava
Copy link
Contributor

Summary

Fixes #3967

Time to review: 12 mins

Changes proposed

Added the initial navigation structure to Storybook

Context for reviewers

Since there wasn't any application logic updated, we can just depend on the normal regression testing. As far as testing Storybook, we must first ensure that it builds properly and the content is correct. At this point, the majority of the content is just placeholders, so it's definitely open for feedback.

Additional information

new-storybook-nav

@@ -25,12 +25,16 @@ const parameters = {
storySort: {
method: "alphabetical",
order: [
"About",
"Brand",
"Core Components",
"Welcome",
"Core",
// Storybook infers the title when not explicitly set, but is case-sensitive
// so we need to explicitly set both casings here for this to properly sort.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 This is great, thanks. 🚀

@karinamzalez
Copy link
Contributor

lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Storybook Nav Tree
3 participants