[Issue #5931] Hide save button when application is submitted #6870

glenblosser-nava · 2025-10-28T16:30:54Z

Summary

Work for #5931

Changes proposed

Adds conditional rendering to the save button, reliant on the application's status not being submitted or accepted

Context for reviewers

#5931

Validation steps

Submit an application in a dev environment, and verify that the save button disappears

glenblosser-nava · 2025-10-28T16:31:34Z

...[locale]/(base)/workspace/applications/application/[applicationId]/form/[appFormId]/page.tsx

 async function FormPage({ params }: formPageProps) {
  const { applicationId, appFormId } = await params;
  const { data, error } = await getFormData({ applicationId, appFormId });
+  let details = {} as ApplicationDetailsCardProps;


This block is copied from the top-level application page, using the same logic to fetch the application information

doug-s-nava

works correctly! a couple minor requests and things to think about

doug-s-nava · 2025-10-28T19:11:47Z

.github/CODEOWNERS

 * @mdragon # project lead

-/documentation/  @acouch @andycochran @btabaska @chouinar @doug-s-nava @joshtonava @mdragon @myduong-navapbc @widal001 @prasnava @jakobpederson @ErinPattisonNava @glenblosser-nava # everyone
+/documentation/  @acouch @andycochran @btabaska @chouinar @doug-s-nava @joshtonava @mdragon @myduong-navapbc @widal001 @prasnava @jakobpederson @ErinPattisonNava @glenblosser-nava @brianlee-nava # everyone


github is saying that @brianlee-nava may not exist or have access to the project. Certainly seems like the user exists, can we confirm access?

I'll double check. He asked me to add him to the codeowners list since I was doing a PR anyway

also wanted to make sure that @brianlee-nava knows what he's signing up for here - any time a PR comes out with an update to documentation he'll be pinged with an email for a review. I'm all for that if he wants to contribute that way, but since none of the other PMs are in the list, wanted to check

MAINTAINERS.md

frontend/src/components/applyForm/ApplyForm.tsx

.github/CODEOWNERS

...[locale]/(base)/workspace/applications/application/[applicationId]/form/[appFormId]/page.tsx

doug-s-nava

a few notes on approach for read only widgets, happy to talk it through

frontend/src/components/applyForm/FormFields.tsx

doug-s-nava · 2025-10-30T13:32:50Z

frontend/src/components/applyForm/widgets/AttachmentUploadWidget.tsx

          name={id}
          required={required}
-          disabled={disabled}
+          disabled={disabled || readonly}


this approach means each widget needs to implement disabling fields based on the "readonly" prop individually. Since each field (except in the budget form) is rendered through the "renderWidget" function, and each widget takes a "disabled" prop, we could do this calculation there instead, and pass "disabled: true" from "renderWidget" into each widget whenever "readonly" is true. We'd still have to figure out the budget form, but this should handle every other widget type without touching the individual widgets themselves

This approach was copied from our other widgets, I can change it if need be. I've gone ahead and had formFields pass both readonly and disabled to its children to simplify future implementation

not sure what you mean about copying from other widgets. My concern is that this way each widget needs to interpret readonly separately when we could potentially isolate that logic in the widget renderer. Maybe we can get on a call to show you what I'm thinking?

doug-s-nava

Want to make sure we're on the same page on where to calculate the disabled props before I approve, but this all works! nice job.

doug-s-nava · 2025-10-31T18:19:57Z

.github/CODEOWNERS

 * @mdragon # project lead

-/documentation/  @acouch @andycochran @btabaska @chouinar @doug-s-nava @joshtonava @mdragon @myduong-navapbc @widal001 @prasnava @jakobpederson @ErinPattisonNava @glenblosser-nava # everyone
+/documentation/  @acouch @andycochran @btabaska @chouinar @doug-s-nava @joshtonava @mdragon @myduong-navapbc @widal001 @prasnava @jakobpederson @ErinPattisonNava @glenblosser-nava @brianlee-nava # everyone


also wanted to make sure that @brianlee-nava knows what he's signing up for here - any time a PR comes out with an update to documentation he'll be pinged with an email for a review. I'm all for that if he wants to contribute that way, but since none of the other PMs are in the list, wanted to check

doug-s-nava · 2025-10-31T18:30:56Z

frontend/src/components/applyForm/FormFields.tsx

  schema: RJSFSchema;
  uiSchema: UiSchema;
  formContext?: RootBudgetFormContext;
+  readonly?: boolean;


sry to not have mentioned this earlier - can we change this to readOnly for camelCase consistency?

doug-s-nava · 2025-10-31T18:33:52Z

frontend/src/components/applyForm/widgets/AttachmentUploadWidget.tsx

          name={id}
          required={required}
-          disabled={disabled}
+          disabled={disabled || readonly}


not sure what you mean about copying from other widgets. My concern is that this way each widget needs to interpret readonly separately when we could potentially isolate that logic in the widget renderer. Maybe we can get on a call to show you what I'm thinking?

doug-s-nava · 2025-11-07T14:25:21Z

frontend/src/components/applyForm/widgets/WidgetRenderers.tsx

    console.error(`Unknown widget type: ${type}`, definition);
    throw new Error(`Unknown widget type: ${type}`);
  }
+  if (props.isFormLocked) {


thanks for making this change - with this in place I think you can roll back the readOnly changes to each of the individual widgets other than the ones that weren't already handling disabled field states (which I think is the attachment widgets and budget form widgets)

doug-s-nava · 2025-11-17T14:07:15Z

split "readonly / disabled" into its own ticket #7067

## Summary Work for #5931 ## Changes proposed When the form is not in progress, the Save button is hidden This PR includes work that will be implemented in a future PR for #5931 ## Context for reviewers This PR is part of larger work on the #5931 ticket, but _only_ features the hidden save button change. The readonly changes are also present in [this](#6870) PR. ## Validation steps After submitting an application, the Save button should not be visible on forms. --------- Co-authored-by: Glen Blosser <[email protected]>

doug-s-nava · 2025-11-24T14:28:46Z

@glenblosser-nava can we close this PR at this point or are you going to come back to it for the disabled fields?

5931 ready for review

13af068

glenblosser-nava commented Oct 28, 2025

View reviewed changes

Glen Blosser and others added 2 commits October 28, 2025 11:33

5931 deconstructing response

5a0e71f

Merge branch 'main' into gblosser/5931-Hide-Save-Button

e5b5df8

glenblosser-nava marked this pull request as ready for review October 28, 2025 16:34

glenblosser-nava requested review from ErinPattisonNava, acouch, andycochran, btabaska, chouinar, doug-s-nava, joshtonava, mdragon, myduong-navapbc and prasnava as code owners October 28, 2025 16:35

glenblosser-nava added 3 commits October 28, 2025 11:40

Adding Brian to codeowners

ea94782

Removing unused import

03899d3

Resolving prettier issues

d826660

glenblosser-nava changed the title ~~5931 ready for review~~ [Issue #5931] Hide save button when application is submitted Oct 28, 2025

doug-s-nava reviewed Oct 28, 2025

View reviewed changes

glenblosser-nava added 2 commits October 28, 2025 14:31

5931 making fields read only when application is submitted

70865bb

Adding test support

a86be7d

doug-s-nava reviewed Oct 30, 2025

View reviewed changes

glenblosser-nava added 2 commits October 30, 2025 15:31

Updating readonly to apply to budget424a correctly

7058fd8

Running prettier

2ce82ed

doug-s-nava reviewed Oct 31, 2025

View reviewed changes

Merge branch 'main' into gblosser/5931-Hide-Save-Button

d38f6d0

glenblosser-nava requested a review from sean-navapbc as a code owner November 4, 2025 17:30

glenblosser-nava added 2 commits November 4, 2025 11:34

Adding support for 424a

2be3a62

Fixing typo in types

e5a99e1

glenblosser-nava added 3 commits November 5, 2025 11:00

5931 Changing readonly vs disabled use

29dceb8

Merge branch 'main' into gblosser/5931-Hide-Save-Button

0487a98

5931 changing lock check to look for in_progress

c191c2d

doug-s-nava reviewed Nov 7, 2025

View reviewed changes

glenblosser-nava mentioned this pull request Nov 7, 2025

Gblosser/5931 hide save button button only #7005

Merged

doug-s-nava closed this Nov 24, 2025

doug-s-nava reopened this Nov 24, 2025

Merged main

3d5fbe7

glenblosser-nava requested a review from chay-REIsys as a code owner November 26, 2025 17:47

Preparing for merge

3639dc1

[Issue #5931] Hide save button when application is submitted #6870

Are you sure you want to change the base?

[Issue #5931] Hide save button when application is submitted #6870

Uh oh!

Conversation

glenblosser-nava commented Oct 28, 2025

Summary

Changes proposed

Context for reviewers

Validation steps

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-s-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-s-nava Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doug-s-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-s-nava left a comment

Choose a reason for hiding this comment

Uh oh!

doug-s-nava Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-s-nava commented Nov 17, 2025

Uh oh!

doug-s-nava commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

doug-s-nava Oct 31, 2025 •

edited

Loading

doug-s-nava Oct 31, 2025 •

edited

Loading