-
Notifications
You must be signed in to change notification settings - Fork 46
[Issue #5931] Hide save button when application is submitted #6870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glenblosser-nava
wants to merge
18
commits into
main
Choose a base branch
from
gblosser/5931-Hide-Save-Button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
13af068
5931 ready for review
5a0e71f
5931 deconstructing response
e5b5df8
Merge branch 'main' into gblosser/5931-Hide-Save-Button
glenblosser-nava ea94782
Adding Brian to codeowners
glenblosser-nava 03899d3
Removing unused import
glenblosser-nava d826660
Resolving prettier issues
glenblosser-nava 70865bb
5931 making fields read only when application is submitted
glenblosser-nava a86be7d
Adding test support
glenblosser-nava 7058fd8
Updating readonly to apply to budget424a correctly
glenblosser-nava 2ce82ed
Running prettier
glenblosser-nava d38f6d0
Merge branch 'main' into gblosser/5931-Hide-Save-Button
glenblosser-nava 2be3a62
Adding support for 424a
glenblosser-nava e5a99e1
Fixing typo in types
glenblosser-nava 29dceb8
5931 Changing readonly vs disabled use
glenblosser-nava 0487a98
Merge branch 'main' into gblosser/5931-Hide-Save-Button
glenblosser-nava c191c2d
5931 changing lock check to look for in_progress
glenblosser-nava 3d5fbe7
Merged main
glenblosser-nava 3639dc1
Preparing for merge
glenblosser-nava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github is saying that @brianlee-nava may not exist or have access to the project. Certainly seems like the user exists, can we confirm access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll double check. He asked me to add him to the codeowners list since I was doing a PR anyway
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also wanted to make sure that @brianlee-nava knows what he's signing up for here - any time a PR comes out with an update to documentation he'll be pinged with an email for a review. I'm all for that if he wants to contribute that way, but since none of the other PMs are in the list, wanted to check