Gblosser/5931 hide save button button only #7005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenblosser-nava
requested review from
ErinPattisonNava,
andycochran,
btabaska,
chouinar,
doug-s-nava,
joshtonava,
mdragon,
myduong-navapbc,
prasnava and
sean-navapbc
as code owners
doug-s-nava
approved these changes
Nov 17, 2025
Collaborator
doug-s-nava
left a comment
doug-s-nava
left a comment
There was a problem hiding this comment.
✅ ✅ ✅ ✅
looks good with the note that there is stuff in here that will bear fruit in the follow up ticket #7067
| console.error(`Unknown widget type: ${type}`, definition); | ||
| throw new Error(`Unknown widget type: ${type}`); | ||
| } | ||
| if (props.isFormLocked) { |
Collaborator
There was a problem hiding this comment.
note that isFormLocked is not being passed, so this won't do anything yet
| required?: boolean; | ||
| disabled?: boolean; | ||
| readonly?: boolean; | ||
| readOnly?: boolean; |
Collaborator
There was a problem hiding this comment.
note that readOnly is not being passed yet, so implementation of this will not be used, but may later be depending on the requirements for #7067
glenblosser-nava
deleted the
gblosser/5931-Hide-Save-Button-Button-Only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work for #5931
Changes proposed
When the form is not in progress, the Save button is hidden
This PR includes work that will be implemented in a future PR for #5931
Context for reviewers
This PR is part of larger work on the #5931 ticket, but only features the hidden save button change. The readonly changes are also present in this PR.
Validation steps
After submitting an application, the Save button should not be visible on forms.