[Issue #7081] Create new endpoint for form instructions documents #7246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehgrantsgov
requested review from
chay-REIsys,
chouinar,
jakobpederson,
joshtonava and
mdragon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7081
Changes proposed
Add a new PUT
/alpha/forms/{form_id}/form_instructions/{form_instruction_id}endpoint to handle uploading and updating form instruction documents.Implemented
upsert_form_instructionservice to manage S3 file uploads, database updates for FormInstructionAdded tests
Context for reviewers
This endpoint enables the management of form instruction files. It requires the UPDATE_FORM privilege.
Note: The form_id in this endpoint is used solely for constructing the S3 path (/forms/{form_id}/...). We intentionally do not link the instruction to the Form record or validate the Form's existence at this stage.
Validation steps
See new tests