use naming fallbackToPlannedTimetableOnNoServiceDate

Author: tkalvas

application/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java

@@ -123,7 +123,7 @@ public Optional<List<TripTimeOnDate>> getScheduledTripTimes(Trip trip) {
   public Optional<List<TripTimeOnDate>> getTripTimeOnDates(
     Trip trip,
     LocalDate serviceDate,
-    boolean fallbackToPlannedTimetableOnNonRunningDate
+    boolean fallbackToPlannedTimetableOnNoServiceDate
   ) {
     TripPattern pattern = findPattern(trip, serviceDate);
 
@@ -134,7 +134,7 @@ public Optional<List<TripTimeOnDate>> getTripTimeOnDates(
     if (times == null) {
       return Optional.empty();
     } else if (!this.getServiceCodesRunningForDate(serviceDate).contains(times.getServiceCode())) {
-      if (fallbackToPlannedTimetableOnNonRunningDate) {
+      if (fallbackToPlannedTimetableOnNoServiceDate) {
         // Technically not returning empty here is incorrect, you should use getScheduledTripTimes
         // above instead if you want this, but it has been the behavior for a very long time, and
         // at least one longstanding front end will fail without this.

application/src/main/java/org/opentripplanner/transit/service/TransitService.java

@@ -75,14 +75,13 @@ public interface TransitService {
 
   /**
    * @return if the trip doesn't run on the specified service date, return scheduled trip times,
-   * unmodified by any realtime data, if
-   * fallbackToNextScheduledDate is true, empty otherwise. Logically this is confusing, but
-   * existing API users depend on this.
+   * unmodified by any realtime data, if fallbackToPlannedTimetableOnNoServiceDate is true, empty
+   * otherwise. Logically this is confusing, but existing API users depend on this.
    */
   Optional<List<TripTimeOnDate>> getTripTimeOnDates(
     Trip trip,
     LocalDate serviceDate,
-    boolean fallbackToPlannedTimetableOnNonRunningDate
+    boolean fallbackToPlannedTimetableOnNoServiceDate
   );
 
   /**

application/src/test/java/org/opentripplanner/transit/service/DefaultTransitServiceTest.java

@@ -242,7 +242,7 @@ void getRealtimeTripTimes() {
   }
 
   @Test
-  void getTripTimeOnDateWithNoServiceAndFallbackToNextScheduledDate() {
+  void getTripTimeOnDateWithNoServiceAndFallbackToPlannedTimetable() {
     assertEquals(
       Optional.of(
         List.of(