Merge pull request #362 from HSLdevcom/empty-transport-mode-allowed

Empty transport mode allowed for topic

Author: thjarvin

pom.xml

@@ -2,7 +2,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>fi.hsl</groupId>
     <artifactId>transitdata-common</artifactId>
-    <version>1.6.2-RC</version>
+    <version>1.6.3-RC</version>
     <packaging>jar</packaging>
     <name>Common utilities for Transitdata projects</name>
     <properties>

src/main/java/fi/hsl/common/hfp/HfpParser.java

@@ -227,7 +227,7 @@ public static Hfp.Topic parseTopic(@NotNull String topic, long receivedAtMs) thr
             final Hfp.Topic.TransportMode transportMode = safeValueOf(Hfp.Topic.TransportMode.class, strTransportMode).orElseThrow(() -> new InvalidHfpTopicException("Unknown transport mode: " + topic));
             builder.setTransportMode(transportMode);
         } else {
-            throw new InvalidHfpTopicException("Transport mode missing");
+            log.info("Transport mode is empty for topic: " + topic);
         }
 
         final String operatorIdStr = parts[index++];
@@ -237,11 +237,11 @@ public static Hfp.Topic parseTopic(@NotNull String topic, long receivedAtMs) thr
             throw new InvalidHfpTopicException("Operator id is not number: " + operatorIdStr);
         }
 
-        final String vehicleNumberString = parts[index++];
+        final String vehicleNumberStr = parts[index++];
         try {
-            builder.setVehicleNumber(Integer.parseInt(vehicleNumberString));
+            builder.setVehicleNumber(Integer.parseInt(vehicleNumberStr));
         } catch (NumberFormatException e) {
-            throw new InvalidHfpTopicException("Vehicle number is not number: " + vehicleNumberString);
+            throw new InvalidHfpTopicException("Vehicle number is not number: " + vehicleNumberStr);
         }
 
         builder.setUniqueVehicleId(createUniqueVehicleId(builder.getOperatorId(), builder.getVehicleNumber()));