Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Team::try_from() when no kicking_team is sent #1577

Open
ThagonDuarte opened this issue Jan 11, 2025 · 0 comments
Open

Fix Team::try_from() when no kicking_team is sent #1577

ThagonDuarte opened this issue Jan 11, 2025 · 0 comments
Labels
is:Bug This is a bug and should be prioritised.
Milestone
Seasongoal 2025

Comments

@ThagonDuarte
Copy link
Contributor

ThagonDuarte commented Jan 11, 2025 •
edited
Loading

The kicking_team of the GameControllerStateMessage is currently not correctly parsed, when no kicking_team is sent. Currently, simply every team_number other than HULKS_TEAM_NUMBER will result in Team::Opponent. The easiest way would be to identify the value the game controller sends, when the kicking_team is supposed to not be transmitted.
For this RoboCup-SPL/GameController3, has to be updated to the current rule set.
@ThagonDuarte ThagonDuarte converted this from a draft issue Jan 11, 2025
@ThagonDuarte ThagonDuarte changed the title Correctly parse GameControllerStateMessage::kicking_team when no kicking_team is sent Fix Team::try_from() when no kicking_team is sent Jan 11, 2025
@ThagonDuarte ThagonDuarte added the is:Bug This is a bug and should be prioritised. label Jan 11, 2025
@ThagonDuarte ThagonDuarte added this to the Seasongoal 2025 milestone Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:Bug This is a bug and should be prioritised.
Projects
Development
Status: Open
Milestone
Seasongoal 2025
Development

No branches or pull requests
1 participant
@ThagonDuarte