Merge pull request #100 from HackAssistant/friends_improvements

Friends improvements

Author: Casassarnau

app/hackathon_variables.py

@@ -20,3 +20,4 @@
 ADMINS = [('Admins', '[email protected]')]
 
 SUPPORTED_RESUME_EXTENSIONS = ['.pdf']
+FRIENDS_MAX_CAPACITY = None

event/templates/checkin_list.html

@@ -47,7 +47,7 @@ <h1 class="">{% translate 'Checkin users' %}{% if admin %} {% translate 'admin'
             let scanner = new Scanner('qr-video', (content) => {
                 if (content.data) {
                     scanner.stop()
-                    window.location.href = '{% url 'checkin_user' 'replace' %}'.replace('replace', content.data)
+                    window.location.href = '{% url 'checkin_user' 'replace' %}'.replace('replace', encodeURIComponent(content.data))
                 }
             }, {
                 popup: true,

friends/models.py

@@ -4,6 +4,8 @@
 from django.conf import settings
 from django.db import models
 
+from application.models import Application, Edition
+
 
 def get_random_string():
     # With combination of lower, upper case and numbers
@@ -16,5 +18,23 @@ class FriendsCode(models.Model):
     code = models.CharField(default=get_random_string, max_length=getattr(settings, "FRIEND_CODE_LENGTH", 13))
     user = models.ForeignKey(settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
 
+    STATUS_NOT_ALLOWED_TO_JOIN_TEAM = [Application.STATUS_CONFIRMED,
+                                       Application.STATUS_INVITED,
+                                       Application.STATUS_ATTENDED]
+
     def get_members(self):
         return FriendsCode.objects.filter(code=self.code)
+
+    def is_closed(self):
+        edition_pk = Edition.get_default_edition()
+        return FriendsCode.objects.filter(
+            code=self.code,
+            user__application_set__edition_id=edition_pk,
+            user__application_set__status__in=self.STATUS_NOT_ALLOWED_TO_JOIN_TEAM
+        ).exists()
+
+    def reached_max_capacity(self):
+        friends_max_capacity = getattr(settings, 'FRIENDS_MAX_CAPACITY', None)
+        if friends_max_capacity is not None and isinstance(friends_max_capacity, int):
+            return FriendsCode.objects.filter(code=self.code).count() >= friends_max_capacity
+        return False

friends/views.py

@@ -63,9 +63,15 @@ def join(self, **kwargs):
         form = FriendsForm(self.request.POST)
         if form.is_valid():
             code = form.cleaned_data.get("friends_code", None)
-            if code is not None and FriendsCode.objects.filter(code=code).exists():
+            friend_code = FriendsCode.objects.filter(code=code).first()
+            if friend_code is None:
+                form.add_error("friends_code", "Invalid code!")
+            elif friend_code.reached_max_capacity():
+                form.add_error("friends_code", "This team is already full")
+            elif friend_code.is_closed():
+                form.add_error("friends_code", "This team has one application invited and cannot be joined")
+            else:
                 return self.create(code=code)
-            form.add_error("friends_code", "Invalid code!")
         context = self.get_context_data()
         context.update({"friends_form": form})
         return self.render_to_response(context)