pkp#10263 Fix 500 error by using userGroup->roleId

Hafsa-Naeem · Hafsa-Naeem · commit a50f6ef44f4f · 2025-04-30T23:10:36.000+05:00
diff --git a/api/v1/submissions/PKPSubmissionController.php b/api/v1/submissions/PKPSubmissionController.php
@@ -1341,7 +1341,7 @@ public function publishPublication(Request $illuminateRequest): JsonResponse
 
         foreach ($stageAssignments as $stageAssignment) {
             $userGroup = $stageAssignment->userGroup;
-            if ($userGroup->getRoleId() === Role::ROLE_ID_AUTHOR) {
+            if ($userGroup && $userGroup->roleId === Role::ROLE_ID_AUTHOR){
                 $stageAssignment->canChangeMetadata = 0;
                 $stageAssignment->save();
             }

Original file line number	Diff line number	Diff line change
`@@ -1341,7 +1341,7 @@ public function publishPublication(Request $illuminateRequest): JsonResponse`
`1341`	`1341`
`1342`	`1342`	`foreach ($stageAssignments as $stageAssignment) {`
`1343`	`1343`	`$userGroup = $stageAssignment->userGroup;`
`1344`		`- if ($userGroup->getRoleId() === Role::ROLE_ID_AUTHOR) {`
	`1344`	`+ if ($userGroup && $userGroup->roleId === Role::ROLE_ID_AUTHOR){`
`1345`	`1345`	`$stageAssignment->canChangeMetadata = 0;`
`1346`	`1346`	`$stageAssignment->save();`
`1347`	`1347`	`}`