Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken menu navigation #3

Closed
OscarL opened this issue Jan 10, 2023 · 4 comments
Closed

Broken menu navigation #3

OscarL opened this issue Jan 10, 2023 · 4 comments

Comments

@OscarL
Copy link
Contributor

OscarL commented Jan 10, 2023

It seems my fix for #1 has broken menus navigation :-(

When opening the "top menu" of an app by "clicking" on it (using KeyCursor, of course), the menu shows up, but immediately disappears after "moving the pointer" (by using the arrow keys).

On the other hand, after invoking "context/popup" menus (e.g.: Tracker's drill-down) via "right click" (SHIFT+Space with KeyCursor) it is possible to to navigate those with no issues.

I guess I'll need a test-app to log what a regular mouse does, and compare that to what KeyCursor is doing.

In the meantime... I'll put on hold the planed update to the HaikuPorts recipe for KeyCursor :-(

@OscarL
Copy link
Contributor Author

OscarL commented Dec 8, 2023

Note to self: these lines (224-227) are the ones that should be restored to fix menu navigation (at the cost of "double-clicking"/"double-spacing" not working on Tracker).

@humdingerb
Copy link
Member

@OscarL , how do you feel about reverting the above mentioned lines and do a release?
It's only the double-click in Tracker, right? At least a double-space for a double-click seems to work in e.g. Genio. In Tracker, it's OK to select with space and then open with RETURN, I guess.

Maybe @jscipione has an idea what's going on here. Him being a Tracker and BMenu specialist... :)

@OscarL
Copy link
Contributor Author

OscarL commented Dec 21, 2023

@humdingerb: I think those lines should be reverted, yes.

I remember that I had tried that "fix" before, reverted it after finding the menu-navigation issue... just to rediscover that "fix" a few months later, when I already had forgotten its side-effects :-/

Your findings match mine... it seems is only on Tracker where the double-click doesn't registers (I do remember it working just fine in BeOS... version 1.1 should be still compilable there, if testing is needed).

A new release with your work in (even with this inconvenience in Tracker), sounds great to me!

@humdingerb
Copy link
Member

Alright. I reverted that part and will upload the catkeys to Polyglot for translation. Then do a release in a week or so.
If a fix for #1 presents itself until then, fine. But Iwouldn't know where to look... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants