In HK 2.x.x, what's the preferred way to determine bandwidth is sufficient before scaling up bitrate / settings?

[jhays]

Please describe your question

HK 1.x.x provided bandwidth notifications in RTMPConnectionDelegate that reported both sufficient and insufficient bandwidth notifications.

public protocol RTMPConnectionDelegate: AnyObject {
  /// Tells the receiver to publish insufficient bandwidth occured.
  func connection(_ connection: RTMPConnection, publishInsufficientBWOccured stream: RTMPStream)
  /// Tells the receiver to publish sufficient bandwidth occured.
  func connection(_ connection: RTMPConnection, publishSufficientBWOccured stream: RTMPStream)
  /// Tells the receiver to update statistics.
  func connection(_ connection: RTMPConnection, updateStats stream: RTMPStream)
}

For 2.x.x, the new approach involves HKStreamBitRateStrategy, which reports NetworkMonitorEvent events:

/// An enumeration that indicate the network monitor event.
public enum NetworkMonitorEvent: Sendable {
  /// To update statistics.
  case status(report: NetworkMonitorReport)
  /// To publish sufficient bandwidth occured.
  case publishInsufficientBWOccured(report: NetworkMonitorReport)
  /// To reset statistics.
  case reset
}

Note that I think there is a typo in the comment- it says "sufficient" but the method is publishInsufficientBWOccured

But it seems there is no longer an equivalent for sufficient: publishSufficientBWOccured.

Our app implemented an adaptive settings approach in which we relied on both of these types of messages. We maintain a list of settings profiles with different bitrates, resolution, and frame rates. If sufficient bandwidth was reported, we might consider increasing the settings level to a higher one. And if insufficient bandwidth was reported, we'd drop down to a lower settings level.

After testing with HaishinKit 2.0.3, I'm finding our previous approach doesn't quite work anymore, as we no longer have an equivalent for publishSufficientBWOccured.

So ultimately that's my question:

In 2.x.x, what's the suggested way to determine when bandwidth is sufficient and we can consider scaling up quality settings?

Would it be possible for publishSufficientBWOccured to be added back in future version? Or is there another approach we should use to periodically check certain stats and make our own determination about when to scale up quality settings?

Thanks!

[shogo4405]

I don't have a development plan, so I'm not sure.
If necessary, I think it would be better to fork and implement it yourself.

[jhays]

I understand, thanks for the quick reply.