Merge pull request #15 from marshallpierce/simplify-num_bins

jonhoo · web-flow · commit ed7f3e0c1abf · 2017-02-18T12:39:36.000-05:00
Use sub_bucket_half_count instead of dividing sub_bucket_count
diff --git a/src/lib.rs b/src/lib.rs
@@ -1276,8 +1276,7 @@ impl<T: Counter> Histogram<T> {
     /// Or, equivalently, we need 1 more bucket to capture the max value if we consider the
     /// sub-bucket length to be halved.
     fn num_bins(&self, number_of_buckets: u8) -> u32 {
-        // TODO use sub_bucket_half_count
-        (number_of_buckets as u32 + 1) * (self.sub_bucket_count / 2)
+        (number_of_buckets as u32 + 1) * (self.sub_bucket_half_count)
     }
 
     /// Compute the number of buckets needed to cover the given value, as well as the total number

Original file line number	Diff line number	Diff line change
`@@ -1276,8 +1276,7 @@ impl<T: Counter> Histogram<T> {`
`1276`	`1276`	`/// Or, equivalently, we need 1 more bucket to capture the max value if we consider the`
`1277`	`1277`	`/// sub-bucket length to be halved.`
`1278`	`1278`	`fn num_bins(&self, number_of_buckets: u8) -> u32 {`
`1279`		`- // TODO use sub_bucket_half_count`
`1280`		`- (number_of_buckets as u32 + 1) * (self.sub_bucket_count / 2)`
	`1279`	`+ (number_of_buckets as u32 + 1) * (self.sub_bucket_half_count)`
`1281`	`1280`	`}`
`1282`	`1281`
`1283`	`1282`	`/// Compute the number of buckets needed to cover the given value, as well as the total number`