Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable error messages #2768

Closed
asmaloney opened this issue Jun 3, 2023 · 3 comments · Fixed by #3054 or #3462
Closed

Unreadable error messages #2768

asmaloney opened this issue Jun 3, 2023 · 3 comments · Fixed by #3054 or #3462
Labels
issue:investigating This issue is being actively investigated.

Comments

@asmaloney
Copy link

Describe the bug

When Heroic brings up a dialog with an error, the text is unreadable.

Also noticed this with the Winetricks dialog.

Guessing it's some dark-vs-light-theme thing. I'm using "Nord Light".

Add logs

(12:40:02) INFO:    [Legendary]:        Refreshing library...
(12:40:02) INFO:    [Connection]:       Connectivity: check-online
(12:40:02) INFO:    [Connection]:       Pinging external endpoints
(12:40:02) INFO:    [Legendary]:        Running command: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary --version
(12:40:02) INFO:    [Legendary]:        Legendary location: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary
(12:40:02) INFO:    [Gog]:              GOGDL location: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/gogdl
(12:40:02) INFO:    [Gog]:              GOGDL location: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/gogdl
(12:40:02) WARNING: [Backend]:          Protocol already registered.
(12:40:02) INFO:    [Connection]:       Connectivity: online
(12:40:02) INFO:    [Backend]:          User Not Found, removing it from Store
(12:40:02) INFO:    [Backend]:          AreWeAntiCheatYet data downloaded
(12:40:02) INFO:    [Backend]:          Loading Screen Ready
(12:40:02) INFO:    [Backend]:          Frontend Ready
(12:40:03) INFO:    [Backend]:          Checking for new Heroic Updates
(12:40:03) INFO:    [Backend]:          Checking for current version changelog
(12:40:05) INFO:    [Winetricks]:       Downloading Winetricks
(12:40:05) INFO:    [Gog]:              Running command: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/gogdl --auth-config-path "/Users/foo/Library/Application Support/heroic/gog_store/auth.json" --version
(12:40:07) WARNING: [Backend]:          Could not determine System Info
(12:40:07) INFO:    [Backend]:          Starting the Download Queue
(12:40:19) INFO:    [Legendary]:        Logging in: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary auth --code <redacted>
(12:40:25) INFO:    [Frontend]:         Refreshing legendary Library
(12:40:25) INFO:    [Legendary]:        Refreshing library...
(12:40:25) INFO:    [Legendary]:        Refreshing Epic Games...
(12:40:25) INFO:    [Legendary]:        Game list updated, got 286 games & DLCs
(12:40:25) INFO:    [Frontend]:         No cache found, getting data from legendary...
(12:40:25) INFO:    [Legendary]:        Refreshing library...
(12:40:25) INFO:    [Legendary]:        Refreshing Epic Games...
(12:40:25) INFO:    [Legendary]:        Game list updated, got 286 games & DLCs
(12:40:25) INFO:    [Frontend]:         Force Update
(12:40:26) INFO:    [Legendary]:        Running command: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary list --third-party
(12:40:26) INFO:    [Legendary]:        Running command: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary list --third-party
(12:40:29) INFO:    [Frontend]:         Refreshing undefined Library
(12:40:29) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(12:40:29) INFO:    [Legendary]:        Refreshing library...
(12:40:29) INFO:    [Legendary]:        Refreshing Epic Games...
(12:40:30) INFO:    [Legendary]:        Game list updated, got 286 games & DLCs
(12:40:30) INFO:    [Legendary]:        Running command: /Applications/Heroic.app/Contents/Resources/app.asar.unpacked/build/bin/darwin/legendary list --third-party

Steps to reproduce

  • logged in
  • went to Library
  • switched to "Downloads" from Library
  • error dialog popped up

Expected behavior

Be able to read the error message.

Screenshots

Screen Shot 2023-06-03 at 12 41 01 PM

If I select the text I can read it:

Screen Shot 2023-06-03 at 12 41 22 PM

Heroic Version

Latest Stable

System Information

Heroic 2.8.0 (note that you should probably not include a version number in the issue template above (2.6.2) - it will constantly be out of date)

macOS 12.6.6

Additional information

No response

@flavioislima flavioislima added the issue:investigating This issue is being actively investigated. label Jun 15, 2023
@arielj
Copy link
Collaborator

arielj commented Sep 17, 2023

Closing this since it seems to be fixed already
image

@arielj arielj closed this as completed Sep 17, 2023
@arielj
Copy link
Collaborator

arielj commented Sep 17, 2023

ooops I was looking at the wrong thing, this is not fixed yet

@asmaloney
Copy link
Author

I don't think this was fixed. I saw one of these errors a few days ago (didn't screenshot it - will next time).

The linked fix seems to be for winetricks itself (which does look correct), not the Legendary error dialog.

Is there a way for me to deliberately trigger a Legendary error?

@arielj arielj reopened this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:investigating This issue is being actively investigated.
Projects
None yet
3 participants