Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWF improvements #135

Open
kaguy4 opened this issue Sep 16, 2024 · 4 comments
Open

SWF improvements #135

kaguy4 opened this issue Sep 16, 2024 · 4 comments
Labels
enhancement For stuff that needs to be improved

Comments

@kaguy4
Copy link
Member

kaguy4 commented Sep 16, 2024

1- SWF files should have their database dimensions displayed next to filesize, just like image files do FIXED!!
2- Kokonotsuba should have a better system for checking dimensions of flash files. When it fails to check, database often logs them as 250x250 px (which comes from MAX_W & MAX_H in config.php - on Flash@Heyuri, I set it to 1000x700 instead for the time being) FIXED!!
3- In thread view, inline expanding them should use the its proper dimensions like fileboards' [Embed] button does, while max-width not exceeding browser's width (100%)

@kaguy4 kaguy4 added the enhancement For stuff that needs to be improved label Sep 16, 2024
@kaguy4
Copy link
Member Author

kaguy4 commented Sep 19, 2024

For 2 - I added these functions to lib_common: 097fb98
but couldn't get them to work on lib_post.php

@kaguy4
Copy link
Member Author

kaguy4 commented Sep 20, 2024

1 and 3 are left
Removing https://github.com/Heyuri/kokonotsuba/blob/main/lib/lib_post.php#L382 solves 1 but it also breaks the thumbnail.

@kaguy4
Copy link
Member Author

kaguy4 commented Sep 20, 2024

1 is done by ceda9b2

3 is left. Inline expanding SWF files should make the dimensions adjust dimensions of individual flash files instead of fixed 640x480 (unless it would exceed screen port, so it should have some CSS like max-width:100% & max-height:100%) - This is probably a JS thing, I don't know why img.js doesn't already do it

@kaguy4
Copy link
Member Author

kaguy4 commented Sep 20, 2024

img.js is currently set to just output "<object width="640" height="480">", which ruffle makes use of
just removing won't work since it seems to default to 550x400 (the default flash project resolution)

anonwaha edit: (wrap HTML and code in backquotes on here, otherwise all or parts of it won't appear)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For stuff that needs to be improved
Projects
None yet
Development

No branches or pull requests

1 participant