Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP/intelephense warnings #161

Open
kaguy4 opened this issue Oct 23, 2024 · 0 comments
Open

Fix PHP/intelephense warnings #161

kaguy4 opened this issue Oct 23, 2024 · 0 comments
Labels
b0rked FIX PLZ

Comments

@kaguy4
Copy link
Member

kaguy4 commented Oct 23, 2024

I believe it's not actually a visible b0rk yet, but code should be fixed:

/lib/fileio/ifs.php

  • Undefined function 'sqlite_exec'.
  • Undefined function 'sqlite_open'.
  • Undefined function 'sqlite_num_rows'.
  • Undefined function 'sqlite_query'.
  • Undefined function 'sqlite_fetch_array'.
  • Undefined function 'sqlite_escape_string'.
  • Undefined constant 'SQLITE_ASSOC'.
  • Undefined function 'sqlite_close'.

/lib/pio/pio.log.php

  • Method 'PIOlog::dbConnect()' is not compatible with method 'IPIO::dbConnect()'. (function dbConnect($connStr))
  • Method 'PIOlog::addPost()' is not compatible with method 'IPIO::addPost()'. (function addPost)

/lib/pio/pio.logflockp.php

  • Method 'PIOlogflockp::dbConnect()' is not compatible with method 'IPIO::dbConnect()'. (function dbConnect($connStr))

/lib/pio/pio.mysql.php

  • VERY LOTS

/lib/pio/pio.mysqli.php

  • Undefined constant 'DEBUG'.
  • Undefined property '$ENV'. ($this->ENV['NONAME'], '', $this->ENV['NOTITLE'], $this->ENV['NOCOMMENT'], '');)
  • Undefined function 'create_function'.
  • Undefined variable '$no'.

/lib/pio/pio.pgsql.php

  • Undefined constant 'DEBUG'.
  • Method 'PIOpgsql::dbConnect()' is not compatible with method 'IPIO::dbConnect()'. (function dbConnect($connStr))
  • Undefined function 'create_function'.
  • Method 'PIOpgsql::addPost()' is not compatible with method 'IPIO::addPost()'. (function addPost)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($category)."',". // 分類標籤)
  • Expected type 'PgSql\Connection'. Found 'int'. ("'".pg_escape_string($pwd)."',".)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($name)."',".)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($email)."',".)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($sub)."',".)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($com)."',".)
  • Expected type 'PgSql\Connection'. Found 'string'. ("'".pg_escape_string($host)."')
  • Expected type 'PgSql\Connection'. Found 'bool'. ('".pg_escape_string($status)."')
  • Expected type 'PgSql\Connection'. Found 'string'. (".pg_escape_string($category).",)

/lib/pio/pio.sqlite.php

  • TEH LOADZ

/lib/pio/pio.sqlite3.php

  • Undefined constant 'DEBUG'.
  • Method 'PIOsqlite3::dbConnect()' is not compatible with method 'IPIO::dbConnect()'. (public function dbConnect($connStr))
  • Undefined function 'create_function'.
  • Method 'PIOsqlite3::addPost()' is not compatible with method 'IPIO::addPost()'. (public function addPost)

/lib/thumb/thumb.imagick.php

  • Undefined type 'Imagick'. ($a = new Imagick(); $b = $a->getVersion(); $b = $b['versionString'];)
  • Undefined type 'Imagick'. ($image = new Imagick($this->sourceFile);)

/lib/thumb/thumb.magickwand.php

  • Undefined function 'MagickGetVersion'.
  • Undefined function 'NewMagickWand'.
  • Undefined function 'MagickReadImage'.
  • Undefined function 'MagickSetImageCompressionQuality'.
  • Undefined function 'MagickThumbnailImage'.
  • Undefined function 'MagickWriteImage'.

/lib/accountIO.php

  • Undefined variable '$fileHandle'. (fclose($fileHandle);)

/lib/lib_cache.php

  • Undefined variable '$cacheFile'. (@chmod($cacheFile.$cacheETag, 0666);)

/lib/lib_common.php

  • Undefined constant 'CAP_ISHTML'. (if($IsAdmin && CAP_ISHTML){ // 管理員開啟HTML)
  • Undefined constant 'TRUST_HTTP_X_FORWARDED_FOR'. (|| !TRUST_HTTP_X_FORWARDED_FOR)

/lib/lib_fileio.php

  • Undefined variable '$config'. (if ($config['CDN_URL'] !== "") {)

/lib/lib_post.php

  • Expected 3 arguments. Found 2. ($email = preg_replace('/^roll( *)/i', '');)
  • Undefined constant 'ID_MODE'. (switch (ID_MODE) {)
  • Undefined constant 'MAX_W'. ($size[0]=MAX_W;)
  • Undefined constant 'MAX_H'. ($size[1]=MAX_H;)

/lib/lib_simplelogger.php

  • Undefined constant 'DEBUG'. (&& DEBUG)

/lib/lib_template.php

  • Undefined function 'total_size'. (total_size(),$config['STORAGE_MAX'])

/module/mod_addinfo.php

  • Undefined property '$dotpoints'. ($this->dotpoints)

/module/mod_adminban.php

  • Undefined variable '$dat'. ($dat.= '';)

/module/mod_antiflood.php

  • Undefined method 'getLastThreadTime'. ($last = $PIO->getLastThreadTime();)

/module/mod_api.php

  • Undefined constant 'STORAGE_PATH'. ($cacheFile = STORAGE_PATH.'cache/api-'.$no.'.';)
  • Undefined constant 'THREAD_PAGINATION'. (if (THREAD_PAGINATION){ // API caching)

/module/mod_bbcode.php

  • Undefined variable '$cnt'. (fwrite($fh, time()."\t$_SERVER[REMOTE_ADDR]\t$cnt\n");)

/module/mod_captcha_old.php

  • Undefined property '$mypage'.
  • Undefined function 'valid'. (if (valid()>=$this->config['roles']['LEV_JANITOR']) return; //no captcha for admin mode)

/module/mod_countryflags.php

  • Undefined type 'GeoIp2\Database\Reader'. ($reader = new Reader(__DIR__.'/geoip/GeoLite2-Country.mmdb');)

/module/mod_movethread.php

  • Undefined method 'getCreds'. ($this->getCreds(CONNECTION_STRING); //get credentials & updatre member cred variables)
  • Undefined constant 'CONNECTION_STRING'. ($this->getCreds(CONNECTION_STRING); //get credentials & updatre member cred variables)
  • Undefined constant 'LEV_MODERATOR'. (if ($AccountIO->valid() < LEV_MODERATOR) error('403 Access denied');)
  • Undefined constant 'S_SQLCONF'. (echo S_SQLCONF; //unable to connect to DB (wrong user/pass?))

/module/mod_pm.php

  • Undefined function 'each'. (while($item = each($_POST)) if($item[1]=='delete') array_push($delno, $item[0]);)

/module/mod_pushpost.php

  • Undefined function 'each'. (while ($item = each($_POST)) {)
  • Undefined constant 'config'. (header('Location: '.fullURL().$this>config['PHP_SELF2'].'?'.time());)

/module/mod_readonly.php

  • Undefined constant 'CAP_NAME'.
  • Undefined constant 'CAP_PASS'.

/module/mod_sticky.php

  • Undefined method 'bumpThread'. (if ($flgh->value('sticky')) $PIO->bumpThread($thread,true);)

/module/mod_sticky.php

  • Undefined function 'each'. (while (list($k, $v) = each($post)) {)

/static/js/preview.js

  • ')' expected. (c = c.replaceAll("\r", "");)

/Utilities/checkenv.php

  • Undefined type 'Imagick'. ($a = new Imagick(); $b = $a->getVersion(); $b = $b['versionString'];)
  • Undefined function 'MagickGetVersion'. ($a = MagickGetVersion(); $b = $a[0];)

/Utilities/log2pio.php

  • Undefined constant 'LOGFILE'. ($logimg = file(LOGFILE); $logimg_cnt = count($logimg);)
  • Undefined constant 'TREEFILE'. ($logtree = array_map('rtrim', file(TREEFILE));)
  • Undefined constant 'IMG_DIR'. ($dirimg = realpath('.').DIRECTORY_SEPARATOR.IMG_DIR;)
  • Undefined constant 'LOGFILE'. (rename(LOGFILE, LOGFILE.'.old');)
  • Undefined constant 'LOGFILE'. ($fs = fopen(LOGFILE, 'w');)

/Utilities/mysql2pio.php

  • ZOMG TONS

/Utilities/pio2pio.php

  • Undefined constant (lots of them)

/Utilities/piov2tov3.php

  • Undefined constant 'CONNECTION_STRING'. ($PIO->dbConnect(CONNECTION_STRING);)
  • Undefined constant 'PIXMICAT_BACKEND'. (switch(PIXMICAT_BACKEND){)

/Utilities/rebuildifs.php

  • Undefined constant 'ROOTPATH'.
  • Undefined constant 'FILEIO_INDEXLOG'.
  • Undefined constant 'IMG_DIR'.
  • Undefined constant 'THUMB_DIR'.

/Utilities/rebuildtree.php

  • Undefined constant 'CONNECTION_STRING'.
@kaguy4 kaguy4 added the b0rked FIX PLZ label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b0rked FIX PLZ
Projects
None yet
Development

No branches or pull requests

1 participant