clippy fixes

Author: andrieshiemstra

src/cache.rs

@@ -23,6 +23,7 @@ struct CacheEntry<O> {
 pub struct Cache<K: std::cmp::Eq + std::hash::Hash, O> {
     // on every get remove and add (oldest items come first)
     entries: LinkedHashMap<K, CacheEntry<O>>,
+    #[allow(clippy::type_complexity)]
     producer: Box<dyn Fn(&K) -> Option<O> + Send>,
     max_inactive_time: Duration,
     inactive_resolution: Duration,

src/js_utils/adapters.rs

@@ -389,16 +389,10 @@ pub trait JsRealmAdapter {
                     args_fac.push(realm.to_js_value_facade(arg)?);
                 }
                 let fut = js_function(this_fac, args_fac);
-                realm.js_promise_create_resolving_async(
-                    async move {
-                        let res = fut.await;
-                        res
-                    },
-                    |realm, pres| {
-                        //
-                        realm.from_js_value_facade(pres)
-                    },
-                )
+                realm.js_promise_create_resolving_async(async move { fut.await }, |realm, pres| {
+                    //
+                    realm.from_js_value_facade(pres)
+                })
             },
             arg_count,
         )

src/js_utils/facades.rs

@@ -235,7 +235,7 @@ pub trait JsRuntimeFacade {
 }
 
 /// the JsValueType represents the type of value for a JSValue
-#[derive(PartialEq, Copy, Clone)]
+#[derive(PartialEq, Copy, Clone, Eq)]
 pub enum JsValueType {
     I32,
     F64,

src/js_utils/facades/values.rs

@@ -214,8 +214,7 @@ impl CachedJsArrayRef {
         &self,
         rti: &R,
     ) -> Result<Vec<JsValueFacade>, JsError> {
-        let res = self
-            .cached_object
+        self.cached_object
             .with_obj(rti, |realm, arr| {
                 let mut vec: Vec<JsValueFacade> = vec![];
                 realm.js_array_traverse_mut(arr, |_index, element| {
@@ -224,8 +223,7 @@ impl CachedJsArrayRef {
                 })?;
                 Ok(vec)
             })
-            .await?;
-        res
+            .await?
     }
 }
 
@@ -454,7 +452,7 @@ impl JsValueFacade {
     }
     pub fn get_str(&self) -> &str {
         match self {
-            JsValueFacade::String { val } => &*val,
+            JsValueFacade::String { val } => val,
             _ => {
                 panic!("Not a string");
             }