add basic versioning

Author: JFriel

Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandCreateNewClassBasedProcessTask.cs

@@ -72,7 +72,7 @@ public override void Execute()
             else
                 return;
         }
-
+        _loadMetadata.Clone();
         var newTask = new ProcessTask(BasicActivator.RepositoryLocator.CatalogueRepository, _loadMetadata, _loadStage)
         {
             Path = _type.FullName,

Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandCreateNewFileBasedProcessTask.cs

@@ -96,7 +96,7 @@ public override void Execute()
                 throw new ArgumentOutOfRangeException($"Unexpected _taskType:{_taskType}");
             }
         }
-
+        _loadMetadata.Clone();
         var task = new ProcessTask((ICatalogueRepository)_loadMetadata.Repository, _loadMetadata, _loadStage)
         {
             ProcessTaskType = _taskType,

Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandDisableOrEnable.cs

@@ -8,7 +8,9 @@
 using Rdmp.Core.Curation.Data;
 using Rdmp.Core.Curation.Data.Aggregation;
 using Rdmp.Core.Curation.Data.Cohort;
+using Rdmp.Core.Curation.Data.DataLoad;
 using Rdmp.Core.MapsDirectlyToDatabaseTable;
+using Rdmp.Core.ReusableLibraryCode;
 
 namespace Rdmp.Core.CommandExecution.AtomicCommands;
 
@@ -72,8 +74,18 @@ public override void Execute()
 
         foreach (var d in _targets)
         {
-            d.IsDisabled = !d.IsDisabled;
-            d.SaveToDatabase();
+            var x = d.GetType();
+            if (d.GetType() == typeof(ProcessTask))
+            {
+                var newVersion = (IDisableable)((IVersionable)d).SaveNewVersion();
+                newVersion.IsDisabled = true;
+                newVersion.SaveToDatabase();
+            }
+            else
+            {
+                d.IsDisabled = !d.IsDisabled;
+                d.SaveToDatabase();
+            }
         }
 
         var toRefresh = _targets.FirstOrDefault();

Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandToggleAllowReservedPrefixForLoadMetadata.cs

@@ -24,6 +24,7 @@ public ExecuteCommandToggleAllowReservedPrefixForLoadMetadata([DemandsInitializa
     public override void Execute()
     {
         base.Execute();
+        _loadMetadata.Clone();
         _loadMetadata.AllowReservedPrefix = !_loadMetadata.AllowReservedPrefix;
         _loadMetadata.SaveToDatabase();
     }

Rdmp.Core/Curation/Data/DataLoad/IProcessTask.cs

@@ -48,7 +48,4 @@ public interface IProcessTask : IRevertable, IArgumentHost, IOrderable, IDisable
     /// </summary>
 #nullable enable
     string? SerialisableConfiguration { get; }
-
-
-    int LoadMetadataVersion { get; }
 }

Rdmp.Core/Curation/Data/DataLoad/LoadMetadata.cs

@@ -45,7 +45,7 @@ public enum CacheArchiveType
 
 /// <inheritdoc cref="ILoadMetadata"/>
 public class LoadMetadata : DatabaseEntity, ILoadMetadata, IHasDependencies, IHasQuerySyntaxHelper,
-    ILoggedActivityRootObject, IHasFolder
+    ILoggedActivityRootObject, IHasFolder, IVersionable
 {
     #region Database Properties
 
@@ -273,7 +273,7 @@ internal LoadMetadata(ICatalogueRepository repository, DbDataReader r)
 
     public LoadMetadata Clone()
     {
-        return new LoadMetadata()
+        var lmd = new LoadMetadata(CatalogueRepository, this.Name)
         {
             LocationOfForLoadingDirectory = LocationOfForLoadingDirectory,
             LocationOfForArchivingDirectory = LocationOfForArchivingDirectory,
@@ -283,13 +283,22 @@ public LoadMetadata Clone()
             Name = Name,
             Description = Description,
             CacheArchiveType = CacheArchiveType,
-            AllowReservedPrefix = AllowReservedPrefix,
+            AllowReservedPrefix = false,
             LastLoadTime = LastLoadTime,
             OverrideRAWServer_ID = OverrideRAWServer_ID,
             IgnoreTrigger = IgnoreTrigger,
             Folder = Folder,
-            RootLoadMetadata_ID = RootLoadMetadata_ID != null?RootLoadMetadata_ID: this.ID
+            RootLoadMetadata_ID = this.ID
         };
+        lmd.SaveToDatabase();
+        //link to catalogue
+        //process task
+        var pts = CatalogueRepository.GetAllObjectsWhere<ProcessTask>("LoadMetadata_ID", this.ID);
+        foreach(ProcessTask pt in pts)
+        {
+            pt.Clone(lmd);
+        }
+        return lmd;
     }
 
     internal LoadMetadata(ShareManager shareManager, ShareDefinition shareDefinition) : base()
@@ -494,4 +503,14 @@ public static bool UsesPersistentRaw(ILoadMetadata loadMetadata)
         return loadMetadata.CatalogueRepository.GetExtendedProperties(ExtendedProperty.PersistentRaw,
             loadMetadata).Any(p => p.Value == "true");
     }
+
+
+    /// <inheritdoc/>
+    public DatabaseEntity SaveNewVersion()
+    {
+        var lmd = this.Clone();
+        lmd.RootLoadMetadata_ID = this.RootLoadMetadata_ID != null ? this.RootLoadMetadata_ID : this.ID;
+        lmd.SaveToDatabase();
+        return lmd;
+    }
 }

Rdmp.Core/Curation/Data/DataLoad/ProcessTask.cs

@@ -16,6 +16,7 @@
 using Rdmp.Core.MapsDirectlyToDatabaseTable;
 using Rdmp.Core.MapsDirectlyToDatabaseTable.Attributes;
 using Rdmp.Core.Repositories;
+using Rdmp.Core.ReusableLibraryCode;
 using Rdmp.Core.ReusableLibraryCode.Annotations;
 using Rdmp.Core.ReusableLibraryCode.Checks;
 
@@ -47,7 +48,6 @@ public class ProcessTask : DatabaseEntity, IProcessTask, IOrderable, INamed, ICh
 #nullable enable
     private string? _SerialisableConfiguration;
 #nullable disable
-    private int _loadMetadataVersion;
 
     /// <summary>
     /// The load the process task exists as part of
@@ -122,7 +122,6 @@ public string? SerialisableConfiguration
     }
 
 
-    public int LoadMetadataVersion { get => _loadMetadataVersion; set => SetField(ref _loadMetadataVersion, value); }
 #nullable disable
 
     #endregion
@@ -207,7 +206,6 @@ internal ProcessTask(ICatalogueRepository repository, DbDataReader r)
         Path = r["Path"] as string;
         Name = r["Name"] as string;
         Order = int.Parse(r["Order"].ToString());
-        LoadMetadataVersion = int.Parse(r["LoadMetadataVersion"].ToString());
         if (Enum.TryParse(r["ProcessTaskType"] as string, out ProcessTaskType processTaskType))
             ProcessTaskType = processTaskType;
         else
@@ -450,4 +448,24 @@ public void SetArgumentValue(string parameterName, object o)
         matchingArgument.SetValue(o);
         matchingArgument.SaveToDatabase();
     }
+
+
+    public ProcessTask Clone(LoadMetadata lmd)
+    {
+        var pt = new ProcessTask(this.CatalogueRepository, lmd, this.LoadStage) {
+            ProcessTaskType = this.ProcessTaskType,
+            Order = this.Order,
+            IsDisabled = this.IsDisabled,
+            SerialisableConfiguration = this.SerialisableConfiguration,
+            Path = this.Path,
+            Name= this.Name,
+        };
+        pt.LoadMetadata_ID = lmd.ID;
+        pt.SaveToDatabase();
+        foreach(var pta in ProcessTaskArguments)
+        {
+            pta.ShallowClone(pt);
+        }
+        return pt;
+    }
 }

Rdmp.Core/Databases/CatalogueDatabase/runAfterCreateDatabase/CreateCatalogue.sql

@@ -774,6 +774,7 @@ CREATE TABLE [dbo].[ProcessTask](
 	[SoftwareVersion] [nvarchar](50) NOT NULL,
 	[IsDisabled] [bit] NOT NULL,
 	[SerialisableConfiguration] [varchar](max),
+	[LoadMetadataVersion] [int],
  CONSTRAINT [PK_ProcessTask] PRIMARY KEY CLUSTERED 
 (
 	[ID] ASC

Rdmp.Core/Providers/CatalogueChildProvider.cs

@@ -998,8 +998,8 @@ private void AddChildren(AllProcessTasksUsedByLoadMetadataNode allProcessTasksUs
     private void AddChildren(LoadStageNode loadStageNode, DescendancyList descendancy)
     {
         var tasks = AllProcessTasks.Where(
-                p => p.LoadMetadata_ID == loadStageNode.LoadMetadata.ID && p.LoadStage == loadStageNode.LoadStage)
-            .OrderBy(o => o.Order).ToArray();
+               p => p.LoadMetadata_ID == loadStageNode.LoadMetadata.ID && p.LoadStage == loadStageNode.LoadStage)
+           .OrderBy(o => o.Order).ToArray();
 
         foreach (var processTask in tasks)
             AddChildren(processTask, descendancy.Add(processTask));