Skip to content

Commit

Permalink
Use XmlException not XmlSyntaxException
Browse files Browse the repository at this point in the history
  • Loading branch information
jas88 committed Nov 30, 2023
1 parent ea99cce commit b9209ac
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Rdmp.Core/Reports/DublinCore/DublinCoreDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using System;
using System.IO;
using System.Linq;
using System.Security;
using System.Xml;
using System.Xml.Linq;

namespace Rdmp.Core.Reports.DublinCore;
Expand Down Expand Up @@ -105,7 +105,7 @@ public void WriteXml(Stream to)
public void LoadFrom(XElement element)
{
if (element.Name != "metadata")
throw new XmlSyntaxException($"Expected metadata element but got {element}");
throw new XmlException($"Expected metadata element but got {element}");

var descendants = element.Descendants().ToArray();
Title = GetElement(descendants, "title", true);
Expand Down Expand Up @@ -137,7 +137,7 @@ private static string GetElement(XElement[] descendants, string tagLocalName, bo
e.Name.LocalName.Equals(tagLocalName, StringComparison.CurrentCultureIgnoreCase));

if (match == null)
return mandatory ? throw new XmlSyntaxException($"Failed to find mandatory tag {tagLocalName}") : null;
return mandatory ? throw new XmlException($"Failed to find mandatory tag {tagLocalName}") : null;

return match.Value.Trim();
}
Expand Down
1 change: 0 additions & 1 deletion Rdmp.UI/Rdmp.UI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
</PackageReference>
<PackageReference Include="ObjectListView.Repack.NET6Plus" Version="2.9.4" />
<PackageReference Include="Scintilla.NET" Version="5.3.2.9" />
<PackageReference Include="System.Security.Permissions" Version="8.0.0" />
<PackageReference Include="System.Resources.Extensions" Version="7.0.0" />
<PackageReference Include="System.Threading.AccessControl" Version="7.0.1" />
<PackageReference Include="VPKSoft.ScintillaLexers.NET" Version="1.1.16" />
Expand Down

0 comments on commit b9209ac

Please sign in to comment.