Skip to content

Commit 8aebe7b

Browse files
Himenonclaude
andcommitted
fix: replace non-null assertions with assert() in generateValidRootSchema tests
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 03088de commit 8aebe7b

2 files changed

Lines changed: 42 additions & 12 deletions

File tree

scripts/testCodeGenWithClass.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,9 @@ const main = () => {
5353
Writer.generateParameter("test/api.test.domain/index.yml", "test/code/class/parameter/api.test.domain.json");
5454
Writer.generateParameter("test/infer.domain/index.yml", "test/code/class/parameter/infer.domain.json");
5555

56-
Writer.generateTypedefWithTemplateCode(
57-
"test/path-parameter/index.yml",
58-
"test/code/class/typedef-with-template/path-parameter.ts",
59-
false,
60-
{ sync: false },
61-
);
56+
Writer.generateTypedefWithTemplateCode("test/path-parameter/index.yml", "test/code/class/typedef-with-template/path-parameter.ts", false, {
57+
sync: false,
58+
});
6259
Writer.generateParameter("test/path-parameter/index.yml", "test/code/class/parameter/path-parameter.json");
6360

6461
Writer.generateFormatTypeCode("test/format.domain/index.yml", "test/code/class/format.domain/code.ts");

src/__tests__/generateValidRootSchema.test.ts

Lines changed: 39 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import assert from "node:assert";
12
import { describe, expect, it } from "vitest";
23
import { generateValidRootSchema } from "../generateValidRootSchema";
34
import type * as Types from "../types";
@@ -28,7 +29,13 @@ describe("generateValidRootSchema", () => {
2829

2930
const result = generateValidRootSchema(input);
3031

31-
const parameter = result.paths!["/items/{id}"]!.get!.parameters![0] as Types.OpenApi.Parameter;
32+
const paths = result.paths;
33+
assert(paths);
34+
const pathItem = paths["/items/{id}"];
35+
assert(pathItem);
36+
const parameters = pathItem.get?.parameters;
37+
assert(parameters);
38+
const parameter = parameters[0] as Types.OpenApi.Parameter;
3239
expect(parameter.required).toBe(true);
3340
});
3441

@@ -50,7 +57,13 @@ describe("generateValidRootSchema", () => {
5057

5158
const result = generateValidRootSchema(input);
5259

53-
const parameter = result.paths!["/items/{id}"]!.get!.parameters![0] as Types.OpenApi.Parameter;
60+
const paths = result.paths;
61+
assert(paths);
62+
const pathItem = paths["/items/{id}"];
63+
assert(pathItem);
64+
const parameters = pathItem.get?.parameters;
65+
assert(parameters);
66+
const parameter = parameters[0] as Types.OpenApi.Parameter;
5467
expect(parameter.required).toBe(true);
5568
});
5669

@@ -71,7 +84,13 @@ describe("generateValidRootSchema", () => {
7184

7285
const result = generateValidRootSchema(input);
7386

74-
const parameter = result.paths!["/items/{id}"]!.parameters![0] as Types.OpenApi.Parameter;
87+
const paths = result.paths;
88+
assert(paths);
89+
const pathItem = paths["/items/{id}"];
90+
assert(pathItem);
91+
const parameters = pathItem.parameters;
92+
assert(parameters);
93+
const parameter = parameters[0] as Types.OpenApi.Parameter;
7594
expect(parameter.required).toBe(true);
7695
});
7796

@@ -88,7 +107,9 @@ describe("generateValidRootSchema", () => {
88107

89108
const result = generateValidRootSchema(input);
90109

91-
const parameter = result.components!.parameters!["ItemId"] as Types.OpenApi.Parameter;
110+
const componentsParameters = result.components?.parameters;
111+
assert(componentsParameters);
112+
const parameter = componentsParameters.ItemId as Types.OpenApi.Parameter;
92113
expect(parameter.required).toBe(true);
93114
});
94115

@@ -109,7 +130,13 @@ describe("generateValidRootSchema", () => {
109130

110131
const result = generateValidRootSchema(input);
111132

112-
const parameter = result.paths!["/items"]!.get!.parameters![0] as Types.OpenApi.Parameter;
133+
const paths = result.paths;
134+
assert(paths);
135+
const pathItem = paths["/items"];
136+
assert(pathItem);
137+
const parameters = pathItem.get?.parameters;
138+
assert(parameters);
139+
const parameter = parameters[0] as Types.OpenApi.Parameter;
113140
expect(parameter.required).toBe(false);
114141
});
115142

@@ -130,7 +157,13 @@ describe("generateValidRootSchema", () => {
130157

131158
const result = generateValidRootSchema(input);
132159

133-
const parameter = result.paths!["/items/{id}"]!.get!.parameters![0] as Types.OpenApi.Parameter;
160+
const paths = result.paths;
161+
assert(paths);
162+
const pathItem = paths["/items/{id}"];
163+
assert(pathItem);
164+
const parameters = pathItem.get?.parameters;
165+
assert(parameters);
166+
const parameter = parameters[0] as Types.OpenApi.Parameter;
134167
expect(parameter.required).toBe(true);
135168
});
136169
});

0 commit comments

Comments
 (0)