fixed sonarcube bugs

Author: Serrof

hipparchus-core/src/main/java/org/hipparchus/linear/FieldQRDecomposition.java

@@ -475,7 +475,6 @@ public FieldMatrix<T> getInverse() {
         private boolean checkSingular(T[] diag,
                                              T min,
                                              boolean raise) {
-            final int len = diag.length;
             for (final T d : diag) {
                 if (FastMath.abs(d.getReal()) <= min.getReal()) {
                     if (raise) {

hipparchus-core/src/main/java/org/hipparchus/linear/QRDecomposition.java

@@ -460,7 +460,6 @@ public RealMatrix getInverse() {
          * {@code raise} is {@code true}.
          */
         private boolean checkSingular(double[] diag, double min, boolean raise) {
-            final int len = diag.length;
             for (final double d : diag) {
                 if (FastMath.abs(d) <= min) {
                     if (raise) {

hipparchus-core/src/main/java/org/hipparchus/util/MathArrays.java

@@ -25,7 +25,6 @@
 import java.lang.reflect.Array;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.Iterator;
 import java.util.List;
@@ -954,7 +953,6 @@ public static void sortInPlace(double[] x,
             throw new NullArgumentException();
         }
 
-        final int yListLen = yList.length;
         final int len = x.length;
 
         for (final double[] y : yList) {

hipparchus-fitting/src/main/java/org/hipparchus/fitting/GaussianCurveFitter.java

@@ -23,7 +23,6 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 

hipparchus-geometry/src/main/java/org/hipparchus/geometry/euclidean/twod/hull/MonotoneChain.java

@@ -23,7 +23,6 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 

hipparchus-ode/src/main/java/org/hipparchus/ode/nonstiff/interpolators/AdamsFieldStateInterpolator.java

@@ -146,7 +146,7 @@ public T[] getScaled() {
      * @return Nordsieck vector
      */
     public Array2DRowFieldMatrix<T> getNordsieck() {
-        return nordsieck;
+        return new Array2DRowFieldMatrix<>(nordsieck.getData());
     }
 
     /** {@inheritDoc} */

hipparchus-ode/src/main/java/org/hipparchus/ode/nonstiff/interpolators/AdamsStateInterpolator.java

@@ -139,7 +139,7 @@ public double[] getScaled() {
      * @return Nordsieck vector
      */
     public Array2DRowRealMatrix getNordsieck() {
-        return nordsieck;
+        return new Array2DRowRealMatrix(nordsieck.getData());
     }
 
     /** {@inheritDoc} */

hipparchus-optim/src/main/java/org/hipparchus/optim/nonlinear/scalar/MultiStartMultivariateOptimizer.java

@@ -22,7 +22,6 @@
 package org.hipparchus.optim.nonlinear.scalar;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 
@@ -34,7 +33,6 @@
 
 /**
  * Multi-start optimizer.
- *
  * This class wraps an optimizer in order to use it several times in
  * turn with different starting points (trying to avoid being trapped
  * in a local extremum when looking for a global one).