Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

wxmac: add --without-mediactrl option to disable dependency on QuickTime #33366

Closed
wants to merge 1 commit into from

Conversation

neapel
Copy link
Contributor

@neapel neapel commented Oct 20, 2014

QuickTime being 32bit only creates some issues, for example wxHaskell uses wx-config --libs output which includes -framework QuickTime when building with mediactrl enabled, and then fails to run on 64bit because the library can't be loaded: jodonoghue/wxHaskell#2

@MikeMcQuaid
Copy link
Member

Isn't this something that could/should by fixed in wxHaskell?

@neapel
Copy link
Contributor Author

neapel commented Oct 20, 2014

It could be fixed in wxHaskell, by filtering the output of wx-config --libs discarding the -framework QuickTime entry, but that seems even more like a hack to me. Especially since the mediactrl library will still appear as available, but when trying to actually use it will complain about missing QuickTime.
When building it without that component, the standard wx-config way just works, for all builds using that approach to create 64bit binaries.

@MikeMcQuaid
Copy link
Member

It seems less usable to me to have users somehow know that this is the magic option they should enable if they want to use wxHaskell. I'd be more open to disabling it globally or at least with 64-bit builds enabled. That said though, it does seem like something that should be fixed upstream in either wxHaskell or wxMac rather than us applying a band-aid.

@EricRFMA
Copy link

Ironically, I'm having the exact same problem building Code::Blocks (which doesn't seem to have anyone maintaining their Mac build, so I thought I'd give it a shot). I'm sure I'll have other problems, but this one is stopping me in my tracks at the moment. Good timing!

@ekmett
Copy link
Contributor

ekmett commented Nov 8, 2014

@MikeMcQuaid, I agree, the issue does hold for anyone building in 64-bit on a mac. The existing 32-bit QuickTime framework will never be upgraded to 64 bit, so in theory it should just be that when you go to build on a 64-bit Mac, you just kill it automatically.

That would remove the need for fancy options and avoid just making the thing unusable for 64-bit users.

@ekmett
Copy link
Contributor

ekmett commented Nov 8, 2014

For now it basically just stops everyone who wants to use the package on a Mac in 64-bit mode dead though.

@MikeMcQuaid
Copy link
Member

@ekmett Please submit an issue to the upstream developers and create a new PR to just disable it globally, thanks!

@ekmett
Copy link
Contributor

ekmett commented Nov 8, 2014

The issue was already been submitted upstream 4 months ago, so in another 8 months or so it will probably become usable. ;)

So if I parsed you correctly, you'd rather have this patch here not be an option, but rather just check for x64 and do the only sensible thing? I'd rather prefer that as well, because then you don't get users going through a monolithic install process only to discover afterwards that they wasted their time.

@MikeMcQuaid
Copy link
Member

So if I parsed you correctly, you'd rather have this patch here not be an option, but rather just check for x64 and do the only sensible thing?

Yup.

ekmett added a commit to ekmett/homebrew that referenced this pull request Nov 29, 2014
)

Users of tools that fail when trying to link non-existent frameworks run into problems on 64-bit macs, because the old 32-bit QuickTime framework does not and never will exist as a 64 bit library.

This has been submitted upstream and accepted into wxmac HEAD, however a released version is not yet available and won't be for quite some time.

This patch lets us actually get code to compile without waiting 8 months for a release.
ekmett added a commit to ekmett/homebrew that referenced this pull request Nov 29, 2014
)

Users of tools that fail when trying to link non-existent frameworks run into problems on 64-bit macs, because the old 32-bit QuickTime framework does not and never will exist as a 64 bit library.

This has been submitted upstream and accepted into wxmac HEAD, however a released version is not yet available and won't be for quite some time.

This patch lets us actually get code to compile without waiting 8 months for a release.
@ekmett
Copy link
Contributor

ekmett commented Nov 29, 2014

I've submitted an alternate patch that acts as requested.

ekmett added a commit to ekmett/homebrew that referenced this pull request Nov 29, 2014
)

Users of tools that fail when trying to link non-existent frameworks run into problems on 64-bit macs, because the old 32-bit QuickTime framework does not and never will exist as a 64 bit library.

This has been submitted upstream and accepted into wxmac HEAD, however a released version is not yet available and won't be for quite some time.

This patch lets us actually get code to compile without waiting 8 months for a release.
sDaniel pushed a commit to sDaniel/homebrew that referenced this pull request Dec 2, 2014
Users of tools that fail when trying to link non-existent frameworks
run into problems on 64-bit macs, because the old 32-bit QuickTime
framework does not and never will exist as a 64 bit library.

This has been submitted upstream and accepted into wxmac HEAD, however
a released version is not yet available and won't be for quite some
time.

This patch lets us actually get code to compile without waiting 8
months for a release.

Closes Homebrew#34543.
Closes Homebrew#33366.

Signed-off-by: Mike McQuaid <[email protected]>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants