Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC device translation not found #13

Open
MoonLiightz opened this issue Jan 21, 2022 · 1 comment
Open

RPC device translation not found #13

MoonLiightz opened this issue Jan 21, 2022 · 1 comment

Comments

@MoonLiightz
Copy link
Contributor

I noticed that for pretty much all device families, the RPC device translations are not loading. The reason seems to be an inconsistency of the language "tags". If you look here, here or here for example, you see that the translation files are in the en-US folder, but Homegear looks for the translations in the non-existing en folder according to this line of code and the following log.

std::string filepath = _bl->settings.deviceDescriptionPath() + std::to_string((int32_t)_family) + "/l10n/" + language + '/' + filename;
if (!Io::fileExists(filepath)) {
filepath = _bl->settings.deviceDescriptionPath() + std::to_string((int32_t)_family) + "/l10n/en/" + filename;
if (!Io::fileExists(filepath)) {
_bl->out.printDebug("Not loading XML RPC device translation " + filepath + ": Translation not found.");
return PHomegearDeviceTranslation();
}
}

Not loading XML RPC device translation /etc/homegear/devices/<family_id>/l10n/en/<device_translation>.xml: Translation not found.

Note: I have debugged the language method parameter, it has the value en for the English language and de for the German language.

The error seems to be caused at latest since this commit: 5559626.
I would say that either for all families the folders must be renamed accordingly or that the language in Homegear must be in "en-US" format again. No matter which format ends up being used, we should agree on a consistent one for everything.

@DevEddy
Copy link

DevEddy commented Sep 22, 2023

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants