You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had an issue with dropdown when searching. Delete key was not affecting input text. I looked into code (Select.js; handleKeyDown function line: 475). There is switch statement to handle some keys including backspace and delete, I assume they should have similar logic but codewise there is a slight difference (maybe unintended).
For backspace - first happens check on (!this.state.inputValue && this.props.backspaceRemoves) and if it's true only then preventDefault and popValue are called (Line: 486)
For delete - no matter what preventDefault is called and then there's check on (!this.state.inputValue && this.props.deleteRemoves). (Line: 560). I assume preventDefault should be inside of if statement.
To reproduce: set 'searchable' to true; enter search text; try to delete symbols using delete key.
The text was updated successfully, but these errors were encountered:
Hello,
I had an issue with dropdown when searching. Delete key was not affecting input text. I looked into code (Select.js; handleKeyDown function line: 475). There is switch statement to handle some keys including backspace and delete, I assume they should have similar logic but codewise there is a slight difference (maybe unintended).
For backspace - first happens check on (!this.state.inputValue && this.props.backspaceRemoves) and if it's true only then preventDefault and popValue are called (Line: 486)
For delete - no matter what preventDefault is called and then there's check on (!this.state.inputValue && this.props.deleteRemoves). (Line: 560). I assume preventDefault should be inside of if statement.
To reproduce: set 'searchable' to true; enter search text; try to delete symbols using delete key.
The text was updated successfully, but these errors were encountered: