Skip to content

Commit b6de5f9

Browse files
authored
chore: enabling linting on __tests__ for the react-native packages (aws-amplify#13545)
* chore: enabling linting on __tests__ for the react-native packages * chore(rtn-push-notification): run yarn lint:fix * chore(rtn-push-notification): manual fix linter errors
1 parent 2ef7c59 commit b6de5f9

File tree

5 files changed

+12
-18
lines changed

5 files changed

+12
-18
lines changed

.eslintrc.js

-12
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,13 @@ module.exports = {
3535
'setupTests.ts',
3636
'jest.setup.*',
3737
'jest.config.*',
38-
// 'packages/adapter-nextjs/__tests__',
39-
// 'packages/analytics/__tests__',
4038
'packages/api/__tests__',
4139
'packages/api-graphql/__tests__',
42-
// 'packages/api-rest/__tests__',
43-
// 'packages/auth/__tests__',
44-
// 'packages/aws-amplify/__tests__',
45-
// 'packages/core/__tests__',
4640
'packages/datastore/__tests__',
4741
'packages/datastore-storage-adapter/__tests__',
48-
// 'packages/geo/__tests__',
4942
'packages/interactions/__tests__',
50-
// 'packages/notifications/__tests__',
5143
'packages/predictions/__tests__',
5244
'packages/pubsub/__tests__',
53-
'packages/react-native/__tests__',
54-
'packages/rtn-push-notification/__tests__',
55-
'packages/rtn-web-browser/__tests__',
56-
// 'packages/storage/__tests__',
5745
],
5846
rules: {
5947
camelcase: [

packages/rtn-push-notification/__tests__/apis/getPermissionStatus.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe('getPermissionStatus', () => {
2323
beforeAll(() => {
2424
mockGetPermissionStatusNative.mockResolvedValue(status);
2525
mockNormalizeNativePermissionStatus.mockImplementation(
26-
status => `normalized-${status}`,
26+
statusParam => `normalized-${statusParam}`,
2727
);
2828
});
2929

packages/rtn-push-notification/__tests__/apis/registerHeadlessTask.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// SPDX-License-Identifier: Apache-2.0
33

44
import { AppRegistry } from 'react-native';
5+
56
import { getConstants } from '../../src/apis/getConstants';
67
import { registerHeadlessTask } from '../../src/apis/registerHeadlessTask';
78
import { normalizeNativeMessage } from '../../src/utils';

packages/rtn-push-notification/__tests__/testUtils/data.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const fcmMessageOptions = {
3333
export const fcmMessagePayload = {
3434
title: 'fcm-title',
3535
body: 'fcm-body',
36-
imageUrl: imageUrl,
36+
imageUrl,
3737
action: {},
3838
rawData: pushNotificationAdhocData,
3939
};

packages/rtn-push-notification/__tests__/utils/normalizeNativeMessage.test.ts

+9-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import {
66
apnsMessage,
77
apnsMessagePayload,
88
fcmMessage,
9-
fcmMessagePayload,
109
fcmMessageOptions,
10+
fcmMessagePayload,
1111
imageUrl,
1212
pushNotificationAdhocData,
1313
pushNotificationDeeplinkUrl,
@@ -23,7 +23,7 @@ describe('normalizeNativeMessage', () => {
2323
expect(normalizeNativeMessage(apnsMessage)).toStrictEqual({
2424
title,
2525
body,
26-
imageUrl: imageUrl,
26+
imageUrl,
2727
data: {
2828
...pushNotificationAdhocData,
2929
'media-url': imageUrl,
@@ -72,12 +72,17 @@ describe('normalizeNativeMessage', () => {
7272

7373
describe('fcm messages', () => {
7474
it('normalizes typical messages', () => {
75-
const { body, rawData, imageUrl, title } = fcmMessagePayload;
75+
const {
76+
body,
77+
rawData,
78+
imageUrl: imageUrlFromPayload,
79+
title,
80+
} = fcmMessagePayload;
7681

7782
expect(normalizeNativeMessage(fcmMessage)).toStrictEqual({
7883
body,
7984
data: rawData,
80-
imageUrl,
85+
imageUrl: imageUrlFromPayload,
8186
title,
8287
fcmOptions: {
8388
...fcmMessageOptions,

0 commit comments

Comments
 (0)