superuser abilities on test instances

Author: HFragnaud

model_validation_api/views.py

@@ -1499,8 +1499,9 @@ def put(self, request, format=None):
                     return Response("To edit a test instance, you need to give an id, or a test_definition_id with a version, or a test_definition_alias with a version ", status=status.HTTP_400_BAD_REQUEST)    
 
             #check if version is editable
-            if not _are_test_code_editable(test_code):
-                return Response("This version is no longer editable as there is at least one result associated with it", status=status.HTTP_400_BAD_REQUEST)
+            if not is_authorised(request,settings.ADMIN_COLLAB_ID):
+                if not _are_test_code_editable(test_code):
+                    return Response("This version is no longer editable as there is at least one result associated with it", status=status.HTTP_400_BAD_REQUEST)
 
             #check if versions are unique
             if not _are_test_code_version_unique(test_code) :

validation_service/app/css/Model_catalog.css

@@ -30,6 +30,30 @@
         background-color: #e1ebf0;
     }
 
+    .superuser-button {
+        white-space: nowrap;
+        padding: 2px 10px;
+        cursor: pointer;
+        background-color: #c43427;
+        border: 2px solid #c43427;
+        color: white;
+        text-align: center;
+        text-decoration: none;
+        font-weight: bold;
+        outline: none;
+        border-radius: 6px;
+    }
+    
+    .superuser-button:hover {
+        background-color: #c43427;
+        color: white;
+    }
+    
+    .superuser-button:active {
+        background-color: #c43427;
+        transform: translateY(1px);
+    }
+    
     .button-MC {
         white-space: nowrap;
         padding: 2px 10px;

validation_service/app/js/controller.js

@@ -305,9 +305,9 @@ testApp.directive("precision", function() {
     };
 });
 
-testApp.controller('ValTestDetailCtrl', ['$scope', '$rootScope', '$http', '$location', '$stateParams', '$state', 'ValidationTestDefinitionRest', 'ValidationTestCodeRest', 'CollabParameters', 'TestCommentRest', "IsCollabMemberRest", "Graphics", "Context", 'TestTicketRest', 'AuthorizedCollabParameterRest', 'ValidationTestAliasRest', 'NotificationRest', 'AreVersionsEditableRest', 'DataHandler',
+testApp.controller('ValTestDetailCtrl', ['$scope', '$rootScope', '$http', '$location', '$stateParams', '$state', 'ValidationTestDefinitionRest', 'ValidationTestCodeRest', 'CollabParameters', 'TestCommentRest', "IsCollabMemberRest", "Graphics", "Context", 'TestTicketRest', 'AuthorizedCollabParameterRest', 'ValidationTestAliasRest', 'NotificationRest', 'AreVersionsEditableRest', 'DataHandler', 'IsSuperUserRest',
 
-    function($scope, $rootScope, $http, $location, $stateParams, $state, ValidationTestDefinitionRest, ValidationTestCodeRest, CollabParameters, TestCommentRest, IsCollabMemberRest, Graphics, Context, TestTicketRest, AuthorizedCollabParameterRest, ValidationTestAliasRest, NotificationRest, AreVersionsEditableRest, DataHandler) {
+    function($scope, $rootScope, $http, $location, $stateParams, $state, ValidationTestDefinitionRest, ValidationTestCodeRest, CollabParameters, TestCommentRest, IsCollabMemberRest, Graphics, Context, TestTicketRest, AuthorizedCollabParameterRest, ValidationTestAliasRest, NotificationRest, AreVersionsEditableRest, DataHandler, IsSuperUserRest) {
 
         $scope.init_graph, $scope.graphic_data, $scope.init_checkbox, $scope.graphic_options;
         $scope.data_for_table;
@@ -644,6 +644,8 @@ testApp.controller('ValTestDetailCtrl', ['$scope', '$rootScope', '$http', '$loca
             $scope.ctx = Context.getCtx();
             $scope.app_id = Context.getAppID();
 
+            $scope.isSuperUser = IsSuperUserRest.get({ app_id: $scope.app_id })
+
             CollabParameters.setService($scope.ctx).then(function() {
 
                 $scope.detail_test = ValidationTestDefinitionRest.get({ app_id: $scope.app_id, id: $stateParams.uuid });
@@ -1549,7 +1551,7 @@ ModelCatalogApp.controller('ModelCatalogEditCtrl', ['$scope', '$rootScope', '$ht
 
                 $scope.version_is_editable = [];
                 $scope.model = ScientificModelRest.get({ app_id: $scope.app_id, id: $stateParams.uuid });
-                console.log("model", $scope.model)
+
                 $scope.model.$promise.then(function(model) {
                     $scope.change_collab_url_to_real_url();
                 });

validation_service/app/templates/validation_framework/validation_test_detail.tpl.html

@@ -162,6 +162,8 @@ <h3 style="font-size:1.5em" align=center><b>Code versions</b></h3><br>
                         <td style="width:5%">
                             <button ng-if="isInArray(code_version.id, version_is_editable)" ng-click="editVersion(code_version.id)" class="button-MC glyphicon glyphicon-pencil">
                                 </button>
+                            <button ng-if="!isInArray(code_version.id, version_is_editable) && isSuperUser.is_superuser" ng-click="editVersion(code_version.id)" class="glyphicon glyphicon-pencil superuser-button">
+                                </button>
                         </td>
 
                         <td>