From 45aa7a6ea16e9beda5c22ab74ba001cb68b4350a Mon Sep 17 00:00:00 2001
From: Andrew Davison <andrew.davison@cnrs.fr>
Date: Sat, 27 Jan 2024 16:40:47 +0100
Subject: [PATCH] fix all errors and warnings from eslint

---
 .eslintrc                            |  6 ++++++
 src/components/BrainScaleSConfig.jsx |  2 +-
 src/components/CodeWidget.jsx        | 24 ++++++++++++------------
 src/components/CreateJobForm.jsx     |  2 +-
 src/components/DriveBrowser.jsx      |  2 +-
 src/components/Introduction.jsx      |  6 +++---
 src/components/JobDetail.jsx         |  2 +-
 src/components/Preview.jsx           |  2 +-
 src/components/ProjectList.jsx       |  2 +-
 src/components/SpiNNakerConfig.jsx   |  8 ++++----
 src/routes/home.jsx                  |  4 ++--
 src/routes/job-creation.jsx          |  4 ++--
 12 files changed, 35 insertions(+), 29 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index a403773..ddcba6f 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -16,8 +16,14 @@
     "browser": true,
     "es2020": true
   },
+  "ignorePatterns" :["coverage", "dist"],
   "rules": {
     "react/react-in-jsx-scope": "off",
     "react/prop-types": "off"
+  },
+  "settings": {
+    "react": {
+      "version": "detect"
+    }
   }
 }
\ No newline at end of file
diff --git a/src/components/BrainScaleSConfig.jsx b/src/components/BrainScaleSConfig.jsx
index 6b7a942..9133677 100644
--- a/src/components/BrainScaleSConfig.jsx
+++ b/src/components/BrainScaleSConfig.jsx
@@ -59,7 +59,7 @@ function BrainScaleSConfig(props) {
         variant="outlined"
         value={formatArray(props.config.HICANN)}
         onChange={(event) => handleChange("HICANN", event.target.value)}
-        onBlur={(event) => removeEmptyItems("HICANN")}
+        onBlur={() => removeEmptyItems("HICANN")}
       />
       <TextField
         id="bss-config-fpga"
diff --git a/src/components/CodeWidget.jsx b/src/components/CodeWidget.jsx
index 850dcfd..f3906dc 100644
--- a/src/components/CodeWidget.jsx
+++ b/src/components/CodeWidget.jsx
@@ -15,6 +15,16 @@ function validURL(value) {
   return value.startsWith("http"); // todo: use a regex
 }
 
+function getPathFromDriveURI(uri, collab) {
+  if (uri.startsWith("drive:")) {
+    const prefix = `drive://${collab}`;
+    return uri.substring(prefix.length + 1);
+  } else if (uri.length > 0) {
+    console.warn("Expected 'drive:' URL, got " + uri);
+  }
+  return uri;
+}
+
 function EditorSizeButtons({ currentHeight, setHeight }) {
   let buttons = [
     <Tooltip key="larger-editor-button" title="Increase editor size">
@@ -67,26 +77,16 @@ function CodeWidget(props) {
     props.onChange(`drive://${props.collab}/${value}`);
   };
 
-  const getPathFromDriveURI = (uri) => {
-    if (uri.startsWith("drive:")) {
-      const prefix = `drive://${props.collab}`;
-      return uri.substring(prefix.length + 1);
-    } else if (uri.length > 0) {
-      console.warn("Expected 'drive:' URL, got " + uri);
-    }
-    return uri;
-  };
-
   useEffect(() => {
     if (props.initialTab === "editor") {
       setCodeFromEditor(props.code || "");
     } else if (props.initialTab === "from-url") {
       setCodeURL(props.code || "");
     } else if (props.initialTab === "drive") {
-      setCodeFromDrive(getPathFromDriveURI(props.code) || "");
+      setCodeFromDrive(getPathFromDriveURI(props.code, props.collab) || "");
     }
     setCurrentTab(props.initialTab);
-  }, [props.initialTab, props.code]);
+  }, [props.initialTab, props.code, props.collab]);
 
   return (
     <Box
diff --git a/src/components/CreateJobForm.jsx b/src/components/CreateJobForm.jsx
index d04ad71..8f6ff17 100644
--- a/src/components/CreateJobForm.jsx
+++ b/src/components/CreateJobForm.jsx
@@ -65,7 +65,7 @@ function CreateJobForm(props) {
     setTags(tags.map((item) => item.trim()).filter((item) => item.length > 0));
   };
 
-  const handleSubmit = (event) => {
+  const handleSubmit = () => {
     const newJob = {
       hardware_platform: hardware,
       code: code,
diff --git a/src/components/DriveBrowser.jsx b/src/components/DriveBrowser.jsx
index ff858d8..06a9a2f 100644
--- a/src/components/DriveBrowser.jsx
+++ b/src/components/DriveBrowser.jsx
@@ -49,7 +49,7 @@ function DriveBrowser(props) {
       setLoading(false);
     }
     fetchData();
-  }, [props.collab, path]);
+  }, [props.collab, path, auth]);
 
   // todo: only show .py, .tar, .tar.gz, .tgz, .zip files
 
diff --git a/src/components/Introduction.jsx b/src/components/Introduction.jsx
index 68d7d1d..1141d5c 100644
--- a/src/components/Introduction.jsx
+++ b/src/components/Introduction.jsx
@@ -4,7 +4,6 @@ import Stack from "@mui/material/Stack";
 import Box from "@mui/material/Box";
 import Typography from "@mui/material/Typography";
 import Container from "@mui/material/Container";
-import Link from "@mui/material/Link";
 
 function Introduction() {
   {
@@ -29,8 +28,9 @@ function Introduction() {
         </Typography>
         <Typography variant="h6" align="center" color="text.secondary" paragraph>
           If you or your colleagues have already run neuromorphic jobs in EBRAINS, you will see
-          below a list of workspaces ("collabs") that contain neuromorphic results. If this is your
-          first time using the EBRAINS neuromorphic systems, click on "Getting started".
+          below a list of workspaces (&ldquo;collabs&rdquo;) that contain neuromorphic results. If
+          this is your first time using the EBRAINS neuromorphic systems, click on &ldquo;Getting
+          started&rdquo;.
         </Typography>
         <Stack sx={{ pt: 4 }} direction="row" spacing={2} justifyContent="center">
           <Button
diff --git a/src/components/JobDetail.jsx b/src/components/JobDetail.jsx
index 539d963..297d21d 100644
--- a/src/components/JobDetail.jsx
+++ b/src/components/JobDetail.jsx
@@ -43,7 +43,7 @@ function JobDetail(props) {
       }, 5000);
       return () => clearInterval(intervalID);
     }
-  }, [props]);
+  }, [props, job, revalidator]);
 
   const handleDeleteTag = async (tag) => {
     console.log(tag);
diff --git a/src/components/Preview.jsx b/src/components/Preview.jsx
index 16b6d62..11d4131 100644
--- a/src/components/Preview.jsx
+++ b/src/components/Preview.jsx
@@ -77,7 +77,7 @@ function Preview(props) {
     if (props.url && props.open) {
       fetchData(props.url, props.content_type, props.size);
     }
-  }, [props.url]);
+  }, [props.url, props.content_type, props.open, props.size]);
 
   const handleClose = () => {
     props.onClose();
diff --git a/src/components/ProjectList.jsx b/src/components/ProjectList.jsx
index f693d1f..33ae4b8 100644
--- a/src/components/ProjectList.jsx
+++ b/src/components/ProjectList.jsx
@@ -22,7 +22,7 @@ function ProjectList(props) {
     if (fetcher.data && selectedProject) {
       fetcher.load();
     }
-  }, [fetcher.data]);
+  }, [fetcher.data, fetcher, selectedProject]);
 
   const handleCloseEditDialog = (projectUpdate) => {
     if (projectUpdate) {
diff --git a/src/components/SpiNNakerConfig.jsx b/src/components/SpiNNakerConfig.jsx
index 5b65d6a..fb5e9c9 100644
--- a/src/components/SpiNNakerConfig.jsx
+++ b/src/components/SpiNNakerConfig.jsx
@@ -64,7 +64,7 @@ function SpiNNakerConfig(props) {
         variant="outlined"
         value={formatArray(props.config.extra_pip_installs)}
         onChange={(event) => handleChange("extra_pip_installs", event.target.value)}
-        onBlur={(event) => removeEmptyItems("extra_pip_installs")}
+        onBlur={() => removeEmptyItems("extra_pip_installs")}
       />
       <TextField
         id="spinn-config-extra_git_repositories"
@@ -74,7 +74,7 @@ function SpiNNakerConfig(props) {
         variant="outlined"
         value={formatArray(props.config.extra_git_repositories)}
         onChange={(event) => handleChange("extra_git_repositories", event.target.value)}
-        onBlur={(event) => removeEmptyItems("extra_git_repositories")}
+        onBlur={() => removeEmptyItems("extra_git_repositories")}
       />
       <TextField
         id="spinn-config-extra_makes"
@@ -84,7 +84,7 @@ function SpiNNakerConfig(props) {
         variant="outlined"
         value={formatArray(props.config.extra_makes)}
         onChange={(event) => handleChange("extra_makes", event.target.value)}
-        onBlur={(event) => removeEmptyItems("extra_makes")}
+        onBlur={() => removeEmptyItems("extra_makes")}
       />
       <TextField
         id="spinn-config-extra-python-setups"
@@ -94,7 +94,7 @@ function SpiNNakerConfig(props) {
         variant="outlined"
         value={formatArray(props.config.extra_python_setups)}
         onChange={(event) => handleChange("extra_python_setups", event.target.value)}
-        onBlur={(event) => removeEmptyItems("extra_python_setups")}
+        onBlur={() => removeEmptyItems("extra_python_setups")}
       />
       <TextField
         id="spinn-config-pyNN_version"
diff --git a/src/routes/home.jsx b/src/routes/home.jsx
index 60388b6..c50f0e2 100644
--- a/src/routes/home.jsx
+++ b/src/routes/home.jsx
@@ -25,7 +25,7 @@ export function getLoader(auth) {
   return loader;
 }
 
-function Home(props) {
+function Home() {
   const data = useLoaderData();
   const navigate = useNavigate();
   const requestedCollabId = useContext(RequestedCollabContext);
@@ -34,7 +34,7 @@ function Home(props) {
     if (requestedCollabId) {
       navigate(`/${requestedCollabId}/jobs/`);
     }
-  }, [requestedCollabId]);
+  }, [requestedCollabId, navigate]);
 
   return (
     <div>
diff --git a/src/routes/job-creation.jsx b/src/routes/job-creation.jsx
index d0f4d02..3983113 100644
--- a/src/routes/job-creation.jsx
+++ b/src/routes/job-creation.jsx
@@ -13,7 +13,7 @@ function submitJob(auth) {
     const { collabId } = params;
     const jobData = await request.json();
     if (request.method === "POST") {
-      const response = await createJob(collabId, jobData, auth);
+      await createJob(collabId, jobData, auth);
       return redirect(`/${collabId}/jobs/`);
     } else {
       throw new Error("unexpected request method");
@@ -22,7 +22,7 @@ function submitJob(auth) {
   return wrappedSubmitJob;
 }
 
-function JobCreationRoute(props) {
+function JobCreationRoute() {
   let { collabId } = useParams();
 
   return (