Skip to content

Commit 56edc36

Browse files
kavya498hkantare
authored andcommitted
Fix: Visibility
1 parent fd88f79 commit 56edc36

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

endpoints/endpoints.go

+18-2
Original file line numberDiff line numberDiff line change
@@ -335,13 +335,21 @@ func (e *endpointLocator) ResourceManagementEndpoint() (string, error) {
335335
if endpoint != "" {
336336
return endpoint, nil
337337
}
338-
if e.visibility == "private" || e.visibility == "public-and-private" {
338+
if e.visibility == "private" {
339339
r, err := validateRegion(e.region, privateRegions["resource"])
340340
if err != nil {
341+
fmt.Println("Private Endpint supports only us-south and us-east region specific endpoint")
341342
return contructEndpoint("private.resource-controller", cloudEndpoint), nil
342343
}
343344
return contructEndpoint(fmt.Sprintf("private.%s.resource-controller", r), cloudEndpoint), nil
344345
}
346+
if e.visibility == "public-and-private" {
347+
r, err := validateRegion(e.region, privateRegions["resource"])
348+
if err != nil {
349+
return contructEndpoint("resource-controller", cloudEndpoint), nil
350+
}
351+
return contructEndpoint(fmt.Sprintf("private.%s.resource-controller", r), cloudEndpoint), nil
352+
}
345353
return contructEndpoint("resource-controller", cloudEndpoint), nil
346354
}
347355

@@ -350,13 +358,21 @@ func (e *endpointLocator) ResourceControllerEndpoint() (string, error) {
350358
if endpoint != "" {
351359
return endpoint, nil
352360
}
353-
if e.visibility == "private" || e.visibility == "public-and-private" {
361+
if e.visibility == "private" {
354362
r, err := validateRegion(e.region, privateRegions["resource"])
355363
if err != nil {
364+
fmt.Println("Private Endpint supports only us-south and us-east region specific endpoint")
356365
return contructEndpoint("private.resource-controller", cloudEndpoint), nil
357366
}
358367
return contructEndpoint(fmt.Sprintf("private.%s.resource-controller", r), cloudEndpoint), nil
359368
}
369+
if e.visibility == "public-and-private" {
370+
r, err := validateRegion(e.region, privateRegions["resource"])
371+
if err != nil {
372+
return contructEndpoint("resource-controller", cloudEndpoint), nil
373+
}
374+
return contructEndpoint(fmt.Sprintf("private.%s.resource-controller", r), cloudEndpoint), nil
375+
}
360376
return contructEndpoint("resource-controller", cloudEndpoint), nil
361377
}
362378

0 commit comments

Comments
 (0)