Fail softly with invalid HTTP methods

Signed-off-by: Alan Cha <[email protected]>

Author: Alan-Cha

packages/openapi-to-graphql/lib/oas_3_tools.js.map

@@ -12,6 +12,7 @@ export declare enum MitigationTypes {
     COMBINE_SCHEMAS = "COMBINE_SCHEMAS",
     DUPLICATE_FIELD_NAME = "DUPLICATE_FIELD_NAME",
     DUPLICATE_LINK_KEY = "DUPLICATE_LINK_KEY",
+    INVALID_HTTP_METHOD = "INVALID_HTTP_METHOD",
     INPUT_UNION = "INPUT_UNION",
     MISSING_RESPONSE_SCHEMA = "MISSING_RESPONSE_SCHEMA",
     MISSING_SCHEMA = "MISSING_SCHEMA",

packages/openapi-to-graphql/lib/preprocessor.js

@@ -263,9 +263,14 @@ export function preprocessOas<TSource, TContext, TArgs>(
           try {
             httpMethod = methodToHttpMethod(rawMethod)
           } catch (e) {
-            throw new Error(
-              `Invalid HTTP method '${rawMethod}' in operation '${operationString}'`
-            )
+            handleWarning({
+              mitigationType: MitigationTypes.INVALID_HTTP_METHOD,
+              message: `Invalid HTTP method '${rawMethod}' in operation '${operationString}'`,
+              data,
+              log: preprocessingLog
+            })
+
+            return
           }
 
           const operation = pathItem[httpMethod] as OperationObject
@@ -395,9 +400,14 @@ export function preprocessOas<TSource, TContext, TArgs>(
                           callbackRawMethod
                         )
                       } catch (e) {
-                        throw new Error(
-                          `Invalid HTTP method '${rawMethod}' in callback '${callbackOperationString}' in operation '${operationString}'`
-                        )
+                        handleWarning({
+                          mitigationType: MitigationTypes.INVALID_HTTP_METHOD,
+                          message: `Invalid HTTP method '${rawMethod}' in callback '${callbackOperationString}' in operation '${operationString}'`,
+                          data,
+                          log: preprocessingLog
+                        })
+
+                        return
                       }
 
                       const callbackOperation = processOperation(

packages/openapi-to-graphql/lib/preprocessor.js.map

@@ -21,6 +21,7 @@ export enum MitigationTypes {
   COMBINE_SCHEMAS = 'COMBINE_SCHEMAS',
   DUPLICATE_FIELD_NAME = 'DUPLICATE_FIELD_NAME',
   DUPLICATE_LINK_KEY = 'DUPLICATE_LINK_KEY',
+  INVALID_HTTP_METHOD = 'INVALID_HTTP_METHOD',
   INPUT_UNION = 'INPUT_UNION',
   MISSING_RESPONSE_SCHEMA = 'MISSING_RESPONSE_SCHEMA',
   MISSING_SCHEMA = 'MISSING_SCHEMA',
@@ -68,6 +69,7 @@ export const mitigations: { [mitigationType in MitigationTypes]: string } = {
   DUPLICATE_FIELD_NAME: 'Ignore field and maintain preexisting field.',
   DUPLICATE_LINK_KEY: 'Ignore link and maintain preexisting link.',
   INPUT_UNION: 'The data will be stored in an arbitrary JSON type.',
+  INVALID_HTTP_METHOD: 'Ignore operation and continue.',
   MISSING_RESPONSE_SCHEMA: 'Ignore operation.',
   MISSING_SCHEMA: 'Use arbitrary JSON type.',
   MULTIPLE_RESPONSES:

packages/openapi-to-graphql/lib/schema_builder.js.map

@@ -5,8 +5,6 @@
 
 'use strict'
 
-const { send } = require('process')
-
 let server // holds server object for shutdown
 
 /**