Promote (#73)

* exposer port in Dockerfile (#71)

* Use PORT env var (e.g. in Code Engine environment) (#72)

Co-authored-by: Youming Lin <[email protected]>

Co-authored-by: Youming Lin <[email protected]>

Author: youming-lin

Dockerfile

@@ -17,4 +17,8 @@ USER 1001
 
 COPY . /app
 ENV FLASK_APP=server/__init__.py
-CMD ["python3", "manage.py", "start", "0.0.0.0:3000"]
+ENV PORT 3000
+
+EXPOSE 3000
+
+CMD ["python3", "manage.py", "start"]

README.md

@@ -56,7 +56,13 @@ Running Flask applications has been simplified with a `manage.py` file to avoid
 pipenv install
 ```
 
-To run your application locally:
+Then, activate this app's virtualenv:
+
+```bash
+pipenv shell
+```
+
+To run your application locally, run this inside the virtualenv:
 
 ```bash
 python manage.py start

manage.py

@@ -1,9 +1,12 @@
 import os, sys, argparse, subprocess, signal
 
+# Tip from:
+# https://github.com/dpgaspar/Flask-AppBuilder/issues/733#issuecomment-379009480
+PORT = int(os.environ.get("PORT", 3000))
+
 # Project defaults
 FLASK_APP = 'server/__init__.py'
-DEFAULT_IP = '0.0.0.0:3000'
-
+DEFAULT_IP = '0.0.0.0:' + str(PORT)
 
 class Command:
     def __init__(self, name, descr, runcmd, env={}):
@@ -99,7 +102,7 @@ def availableCommands(self):
                                  formatter_class=argparse.RawDescriptionHelpFormatter)
 parser.add_argument("subcommand", help="subcommand to run (see list above)")
 parser.add_argument("ipaddress", nargs='?', default=DEFAULT_IP,
-                    help="address and port to run on (i.e. {0})".format(DEFAULT_IP))
+                    help="address and port to run on (i.e. 0.0.0.0:3000)")
 
 
 def livereload_check():