Skip to content

Conversation

@MeSophie
Copy link
Contributor

@MeSophie MeSophie commented Oct 30, 2025

Partly Fixes #10016
Fixes #10015
@Ag-Derek @berylwaswa @rachelkg This is the second step to solve french translation issue in Some dialogues reported in #10016. I have added some text in the Json file and make a Small layout change in the Describe>Graphs>Boxplot dialogue. Please Have a look.
I also Fixed some layout issue.
1- In issue #9997
In Prepare> column:Numeric>Rows Sumary
image

In Prepare> column:Numeric>Permute/Sample Row
image

2- In issue #9995
Prepare>Check Data>Ananymise ID Column.
image

Prepare > Check Data>One Variables Frequencies.
image

Prepare>Check Data >Pivot Table
image

-Prepare>Check Data>Compare Columns.
image

3- In issue #9994
Prepare>Data Frame> Select Column Dialogue.
image

Prepare>Data Frame > Duplicate Column Dialogue.
image

4- In Issue #9783
Prepare> Table>summary
image

@gemini-code-assist
Copy link

Summary of Changes

Hello @MeSophie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents the second step in addressing a French translation issue by introducing new English text strings that will facilitate accurate localization. Concurrently, it refines the user interface of the Boxplot dialogue by making minor layout adjustments to various controls, ensuring a consistent and improved visual presentation.

Highlights

  • Translation Updates: New text strings, including 'Add Boxplot', 'Label Outliers', and several 'Summary_' related keys, have been added to the English translation file to support upcoming French translations.
  • Typo Correction: A minor typo in the English translation file was corrected, changing 'Outlier Coefficiennt :' to 'Outlier Coefficient :'.
  • UI Layout Adjustments: Small layout changes were made in the 'Describe > Graphs > Boxplot' dialogue, primarily adjusting margin properties and the position/size of certain controls for better visual alignment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces layout changes to the Boxplot dialogue and updates the English translation file. The changes in the designer.vb file are minor and appropriate. In the JSON translation file, you've added new keys and fixed a typo, which is great. However, I've identified a high-severity issue where the typo fix in the translation file isn't reflected in the UI source code, which will prevent the translation from working. I've also included a medium-severity suggestion to improve the maintainability of the new translation keys.

"Outer": "Outer",
"Outlier": "Outlier",
"Outlier Coefficiennt :": "Outlier Coefficiennt :",
"Outlier Coefficient :": "Outlier Coefficient :",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you've corrected the typo for Outlier Coefficient : in this translation file, the source code that displays this text in the UI has not been updated. The Text property for lblOutlierCoefficient in instat/dlgBoxPlot.designer.vb on line 550 is still set to the old value with the typo: "Outlier Coefficiennt :".

For the translation to work, the text in the source code must exactly match the key in this JSON file. Please update the Text property in the designer file to match the corrected key.

Comment on lines +5320 to +5322
"Summary_count": "Summary_count",
"Summary_count_all": "Summary_count_all",
"Summary_sum": "Summary_sum",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new keys Summary_count, Summary_count_all, and Summary_sum appear to be internal identifiers rather than user-facing text. For translation files, it's a best practice to use the full, descriptive English text as the key. This provides essential context for translators, making their job easier and reducing the chance of incorrect translations. Using identifiers as keys can be confusing without additional context.

If these are indeed for UI text, consider changing them to be more descriptive. For example, "Summary (count)" is more explicit than "Summary_count".

Suggested change
"Summary_count": "Summary_count",
"Summary_count_all": "Summary_count_all",
"Summary_sum": "Summary_sum",
"Summary (count)": "Summary (count)",
"Summary (count all)": "Summary (count all)",
"Summary (sum)": "Summary (sum)",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

French Translation Issue and Solutions On Prepare >Data Frame Dialogues French Translation Issue and Solutions On Prepare >Pivot Table

1 participant