Added in "Save Definitions" Option to End of Rain/Seasons Dialog for PICSA #10049

Vitalis95 · 2025-11-01T16:23:11Z

Fixes partially #10041
@lilyclements @berylwaswa , I have implemented Save Definitions" Option to the End of Rain/Seasons Dialog. Please check

update

gemini-code-assist · 2025-11-01T16:23:27Z

Summary of Changes

Hello @Vitalis95, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the 'End of Rain/Seasons Dialog' by providing users with the ability to save their defined rain and season parameters. This feature improves the usability and reproducibility of analyses within the PICSA application by allowing users to persist and reuse their custom definitions, rather than re-entering them for each session.

Highlights

New 'Save Definitions' Option: A new 'Save Definitions' checkbox and an associated save control (ucrSaveObject) have been added to the 'End of Rain/Seasons Dialog' user interface.
Dynamic Definition Saving Logic: The application now dynamically constructs and executes R functions (clsGetEndRainDefFunction) to save end-of-rain/season definitions, based on whether the 'Save Definitions' option is checked and which season definition method (Date, Doy, or Occurence) is selected.
R Function Integration: Several new RFunction objects (clsGetEndRainDefFunction, clsGetCalculationsFunction, clsGetOffsetTermFunction, clsGetDataframeFunction) have been introduced and configured to support the retrieval and saving of definition-related data from the R environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a 'Save Definitions' option to the End of Rain/Seasons dialog. The changes include modifications to the UI designer file to add the new controls and updates to the code-behind to implement the logic for saving the definitions. The implementation looks mostly correct, but I've found a couple of issues. One is a potentially script-breaking bug due to a typo in a variable name, and the other is a minor UI text issue that could confuse users. My review includes suggestions to fix these issues.

gemini-code-assist · 2025-11-01T16:24:17Z

instat/dlgEndOfRainsSeason.vb

+        clsGetCalculationsFunction.SetAssignTo("calculations_data")
+
+        clsGetOffsetTermFunction.SetRCommand(frmMain.clsRLink.strInstatDataObject & "$get_offset_term")
+        clsGetOffsetTermFunction.SetAssignTo("definitions_offset ")


There is a trailing space in the variable name "definitions_offset ". This will create an invalid variable name in R and cause the script to fail. The space should be removed.

clsGetOffsetTermFunction.SetAssignTo("definitions_offset")

gemini-code-assist · 2025-11-01T16:24:18Z

instat/dlgEndOfRainsSeason.vb

+        ucrSaveObject.SetPrefix("end_rain_definition")
+        ucrSaveObject.SetSaveType(strRObjectType:=RObjectTypeLabel.StructureLabel, strRObjectFormat:=RObjectFormat.Text)
+        ucrSaveObject.SetDataFrameSelector(ucrSelectorForWaterBalance.ucrAvailableDataFrames)
+        ucrSaveObject.SetLabelText("Survival Object Name:")


The label text for ucrSaveObject is set to "Survival Object Name:", which seems unrelated to saving rain definitions and might be a copy-paste artifact. A more descriptive label like "Definition Object Name:" would be clearer for the user, especially since the object prefix is set to end_rain_definition.

ucrSaveObject.SetLabelText("Definition Object Name:")

lilyclements

When I ran this it ran for get_end_rains_definition:

end_rain_definition <- get_end_rains_definition(summary_data, calculations_data, end_rains_date=end_season_date, definitions_offset)

We want to have end_rains_date equal the name of the variable in the ucrSave (e.g., "end_rains_date")
It also is missing out the end_rains parameter

lilyclements

Some very minor changes

lilyclements · 2025-11-01T17:11:00Z

instat/dlgEndOfRainsSeason.vb

        ucrChkEndofSeasonDoy.SetLinkedDisplayControl(grpEndofSeason)
        ucrNudTotalOverDays.SetLinkedDisplayControl(lblTotalOverDays)

+        ucrSaveObject.SetPrefix("end_rain_definition")


can this be end_rains_definition, just to be consistent with the other naming conventions in the other saves

lilyclements · 2025-11-01T17:11:49Z

instat/dlgEndOfRainsSeason.vb

+        If ucrChkDefinitions.Checked Then
+            ucrBase.clsRsyntax.AddToAfterCodes(clsGetEndRainDefFunction, iPosition:=13)
+            If ucrChkEndofSeasonDate.Checked Then
+                clsGetEndRainDefFunction.AddParameter("end_rains_date", ucrInputEndofSeasonDate.GetText, iPosition:=2)


Ah! I think this is where the error is. This should be ucrInputEndofRainsDate

And you want them in quotes, i.e.,

clsGetEndRainDefFunction.AddParameter("end_rains_date", Chr(34) & ucrInputEndofRainsDate.GetText & Chr(34), iPosition:=2)

lilyclements · 2025-11-01T17:12:04Z

instat/dlgEndOfRainsSeason.vb

+            If ucrChkEndofSeasonDate.Checked Then
+                clsGetEndRainDefFunction.AddParameter("end_rains_date", ucrInputEndofSeasonDate.GetText, iPosition:=2)
+            ElseIf ucrChkEndofSeasonDoy.Checked Then
+                clsGetEndRainDefFunction.AddParameter("end_rains", ucrInputSeasonDoy.GetText, iPosition:=3)


ucrInputRainsDoy and in quotes

lilyclements · 2025-11-01T17:12:19Z

instat/dlgEndOfRainsSeason.vb

+                clsGetEndRainDefFunction.AddParameter("end_rains", ucrInputSeasonDoy.GetText, iPosition:=3)
+
+            ElseIf ucrChkEndofSeasonOccurence.Checked Then
+                clsGetEndRainDefFunction.AddParameter("end_rains_status", ucrInputEndofSeasonOccurence.GetText, iPosition:=4)


And again here for the End of Rains, not Season (and quotes)

Vitalis95 · 2025-11-01T19:22:11Z

@lilyclements , have a look at it

lilyclements

@Vitalis95 good - only a couple of minor things

I made a minor fix in the parameter names for get_end_season_definition so can you pull your changes?
If it is end of season, then the base function is "get_end_season_definition"
(You did "get_end_rains_definition" for them both)
If it is end of season, can the ucrSave say "end_season_definition"

Vitalis95 · 2025-11-02T09:31:52Z

@lilyclements , check it again

lilyclements

@Vitalis95 this is crashing for me for the end season option. Is it working for you?

Vitalis95 · 2025-11-02T15:48:49Z

@Vitalis95 this is crashing for me for the end season option. Is it working for you?

@lilyclements I get this error

Vitalis95 and others added 4 commits October 12, 2025 14:31

Merge pull request #362 from IDEMSInternational/master

45472e6

update

Merge pull request #363 from IDEMSInternational/master

6afb816

update

Merge pull request #364 from IDEMSInternational/master

1bb16a6

update

changes to the code

2c55e46

gemini-code-assist bot reviewed Nov 1, 2025

View reviewed changes

changes

f91a3cb

lilyclements reviewed Nov 1, 2025

View reviewed changes

lilyclements requested changes Nov 1, 2025

View reviewed changes

changes

9ba8af2

Rename parameters for end season functionality

84393a2

lilyclements requested changes Nov 2, 2025

View reviewed changes

changes

1992be2

lilyclements requested changes Nov 2, 2025

View reviewed changes

Added in "Save Definitions" Option to End of Rain/Seasons Dialog for PICSA #10049

Are you sure you want to change the base?

Added in "Save Definitions" Option to End of Rain/Seasons Dialog for PICSA #10049

Conversation

Vitalis95 commented Nov 1, 2025

Uh oh!

gemini-code-assist bot commented Nov 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyclements left a comment

Choose a reason for hiding this comment

Uh oh!

lilyclements left a comment

Choose a reason for hiding this comment

Uh oh!

lilyclements Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyclements Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyclements Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

lilyclements Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lilyclements Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vitalis95 commented Nov 1, 2025

Uh oh!

lilyclements left a comment

Choose a reason for hiding this comment

Uh oh!

Vitalis95 commented Nov 2, 2025

Uh oh!

lilyclements left a comment

Choose a reason for hiding this comment

Uh oh!

Vitalis95 commented Nov 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lilyclements Nov 1, 2025 •

edited

Loading

lilyclements Nov 1, 2025 •

edited

Loading